-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move modals outside of form elements #711
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Jinaga LLC" |
@neelavarshad please review as needed. |
Hi @michaellperry can you provide with some repro steps please, im trying but unable |
reaching out again to see any repro steps for the issue please. |
WIP-9/30/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution is acceptable but PR should've been submitted using request format.
- We should also review the design and flow of the dialog for improvements.
will merge after release 8 |
The modals in both the admin and landing page subscription lists were not working. The spinner would keep spinning indefinitely after the user pressed the button.
The cause was that the form element that the JavaScript attempted to submit did not exist. The form was nested within another form. As a result, the browser removed it from the DOM.
This change moves the modal container outside of the outer form element so that it's inner form would not be nested.