Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move modals outside of form elements #711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaellperry
Copy link

The modals in both the admin and landing page subscription lists were not working. The spinner would keep spinning indefinitely after the user pressed the button.

The cause was that the form element that the JavaScript attempted to submit did not exist. The form was nested within another form. As a result, the browser removed it from the DOM.

This change moves the modal container outside of the outer form element so that it's inner form would not be nested.

@michaellperry
Copy link
Author

@microsoft-github-policy-service agree company="Jinaga LLC"

@neelavarshad neelavarshad self-requested a review June 6, 2024 16:09
@neelavarshad neelavarshad self-assigned this Jun 6, 2024
@santhoshb-msft
Copy link
Contributor

@neelavarshad please review as needed.

@santhoshb-msft
Copy link
Contributor

Hi @michaellperry can you provide with some repro steps please, im trying but unable

@santhoshb-msft
Copy link
Contributor

reaching out again to see any repro steps for the issue please.

@michaellperry
Copy link
Author

Administer your SaaS offer in the SaaS Accelerator admin portal.
image

Go to the Application Config section. Select the "AcceptSubscriptionUpdates" setting.
image

Edit the setting and change the value to "true".
image

Go to the "Plans" page. Ensure that you have more than one plan.
image

Next log into the Azure Portal. Subscribe to your offer.
image

Activate the subscription and go to the subscription list.
image

Select "Change Plan" in the menu next to the subscription.
image

The change plan dialog appears. Select a different plan.
image

Click the "Change Plan" button. It does not respond.
image

@fthorntonai
Copy link
Collaborator

WIP-9/30/2024

Copy link
Collaborator

@fthorntonai fthorntonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is acceptable but PR should've been submitted using request format.

  • We should also review the design and flow of the dialog for improvements.

@santhoshb-msft
Copy link
Contributor

will merge after release 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants