Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send localhost as the name for dhclient #2930

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edwardsp
Copy link
Contributor

@edwardsp edwardsp commented Sep 22, 2023

The DHCP hostname is set to localhost.localdomain after running waagent -deprovision. This causes localhost to be added to Azure DNS and a call to nslookup localhost from somewhere on the VNET can get another VMs private IP address.

This PR has a proposed solution for this.

Description

Issue #2928


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

This causes localhost to be added to Azure DNS and a call to
`nslookup localhost` from somewhere on the VNET can get another VMs
private IP address.
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2930 (a42b4b8) into master (28345a5) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2930      +/-   ##
==========================================
- Coverage   71.97%   71.94%   -0.03%     
==========================================
  Files         104      104              
  Lines       15873    15879       +6     
  Branches     2273     2276       +3     
==========================================
  Hits        11424    11424              
- Misses       3926     3932       +6     
  Partials      523      523              
Files Coverage Δ
azurelinuxagent/common/osutil/redhat.py 51.02% <0.00%> (-1.07%) ⬇️
azurelinuxagent/common/osutil/suse.py 44.68% <0.00%> (-0.98%) ⬇️
azurelinuxagent/common/osutil/default.py 59.79% <0.00%> (-0.13%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant