Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support specify cache file for credscan index #94

Merged
merged 1 commit into from
Apr 16, 2024
Merged

support specify cache file for credscan index #94

merged 1 commit into from
Apr 16, 2024

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Apr 15, 2024 •
edited
Loading

  1. fix index resolve issue when running in windows powershell with path seperator (\)
  2. add -swagger-index-file option for armstrong credscan, omit this will use the online swagger index file or locally build index, and if not exists, downloaded or built index will be saved to the file.

ms-henglu
ms-henglu approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@ms-henglu ms-henglu merged commit 79138d0 into Azure:main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms-henglu ms-henglu ms-henglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teowa @ms-henglu