Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM] Fix #26112: az deployment group create: Fix the warning log mode is not a known attribute of class TemplateLink #26984

Merged
merged 4 commits into from
Jul 31, 2023
Merged

[ARM] Fix #26112: az deployment group create: Fix the warning log mode is not a known attribute of class TemplateLink #26984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8b7775
remove mode property from template specs sdk reference
Jul 21, 2023
52cc3e6
Merge branch 'dev' of https://github.com/detienne20/azure-cli into da…
Jul 24, 2023
b9d90f1
fix spelling
Jul 28, 2023
5b911b1
rerecord in live mode
Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/resource/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ def on_request(self, request):
template = http_request.data["properties"]["template"]
del http_request.data["properties"]["template"]

# templateLink nad template cannot exist at the same time in deployment_dry_run mode
# templateLink and template cannot exist at the same time in deployment_dry_run mode
if "templateLink" in http_request.data["properties"].keys():
del http_request.data["properties"]["templateLink"]

Expand Down Expand Up @@ -961,7 +961,7 @@ def _prepare_deployment_properties_unmodified(cmd, deployment_scope, template_fi
template_link = TemplateLink(uri=template_uri)
template_obj = _remove_comments_from_json(_urlretrieve(template_uri).decode('utf-8'), file_path=template_uri)
elif template_spec:
template_link = TemplateLink(id=template_spec, mode="Incremental")
template_link = TemplateLink(id=template_spec)
# The api-version for ResourceType.MGMT_RESOURCE_RESOURCES may get updated and point to another (newer) version of the api version for
# ResourceType.MGMT_RESOURCE_TEMPLATESPECS than our designated version. This ensures the api-version of all the rest requests for
# template_spec are consistent in the same profile:
Expand Down
Loading
Loading