Skip to content

Commit

Permalink
reverts rp version
Browse files Browse the repository at this point in the history
  • Loading branch information
ReneHezser committed Oct 28, 2024
1 parent e8cf3cc commit ec4fc23
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 18 deletions.
19 changes: 7 additions & 12 deletions avm/res/signal-r-service/signal-r/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ This module deploys a SignalR Service SignalR.
| `Microsoft.Authorization/roleAssignments` | [2022-04-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2022-04-01/roleAssignments) |
| `Microsoft.Network/privateEndpoints` | [2023-11-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/2023-11-01/privateEndpoints) |
| `Microsoft.Network/privateEndpoints/privateDnsZoneGroups` | [2023-11-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/2023-11-01/privateEndpoints/privateDnsZoneGroups) |
| `Microsoft.SignalRService/signalR` | [2024-03-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.SignalRService/2024-03-01/signalR) |
| `Microsoft.SignalRService/signalR` | [2022-02-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.SignalRService/2022-02-01/signalR) |

## Usage examples

Expand Down Expand Up @@ -978,13 +978,15 @@ Custom DNS configurations.

| Parameter | Type | Description |
| :-- | :-- | :-- |
| [`fqdn`](#parameter-privateendpointscustomdnsconfigsfqdn) | string | Fqdn that resolves to private endpoint IP address. |
| [`ipAddresses`](#parameter-privateendpointscustomdnsconfigsipaddresses) | array | A list of private IP addresses of the private endpoint. |

**Optional parameters**
### Parameter: `privateEndpoints.customDnsConfigs.fqdn`

| Parameter | Type | Description |
| :-- | :-- | :-- |
| [`fqdn`](#parameter-privateendpointscustomdnsconfigsfqdn) | string | FQDN that resolves to private endpoint IP address. |
Fqdn that resolves to private endpoint IP address.

- Required: No
- Type: string

### Parameter: `privateEndpoints.customDnsConfigs.ipAddresses`

Expand All @@ -993,13 +995,6 @@ A list of private IP addresses of the private endpoint.
- Required: Yes
- Type: array

### Parameter: `privateEndpoints.customDnsConfigs.fqdn`

FQDN that resolves to private endpoint IP address.

- Required: No
- Type: string

### Parameter: `privateEndpoints.customNetworkInterfaceName`

The custom name of the network interface attached to the Private Endpoint.
Expand Down
2 changes: 1 addition & 1 deletion avm/res/signal-r-service/signal-r/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ resource avmTelemetry 'Microsoft.Resources/deployments@2024-03-01' = if (enableT
}
}

resource signalR 'Microsoft.SignalRService/signalR@2024-03-01' = {
resource signalR 'Microsoft.SignalRService/signalR@2022-02-01' = {
name: name
location: location
kind: kind
Expand Down
10 changes: 5 additions & 5 deletions avm/res/signal-r-service/signal-r/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.30.23.60470",
"templateHash": "7109443914368923423"
"templateHash": "16927696189835004733"
},
"name": "SignalR Service SignalR",
"description": "This module deploys a SignalR Service SignalR.",
Expand Down Expand Up @@ -667,7 +667,7 @@
},
"signalR": {
"type": "Microsoft.SignalRService/signalR",
"apiVersion": "2024-03-01",
"apiVersion": "2022-02-01",
"name": "[parameters('name')]",
"location": "[parameters('location')]",
"kind": "[parameters('kind')]",
Expand Down Expand Up @@ -1527,14 +1527,14 @@
"metadata": {
"description": "The location the resource was deployed into."
},
"value": "[reference('signalR', '2024-03-01', 'full').location]"
"value": "[reference('signalR', '2022-02-01', 'full').location]"
},
"systemAssignedMIPrincipalId": {
"type": "string",
"metadata": {
"description": "The principal ID of the system assigned identity."
},
"value": "[coalesce(tryGet(tryGet(reference('signalR', '2024-03-01', 'full'), 'identity'), 'principalId'), '')]"
"value": "[coalesce(tryGet(tryGet(reference('signalR', '2022-02-01', 'full'), 'identity'), 'principalId'), '')]"
},
"privateEndpoints": {
"type": "array",
Expand All @@ -1553,4 +1553,4 @@
}
}
}
}
}

0 comments on commit ec4fc23

Please sign in to comment.