Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added disclaimer to container-app ptn - avm/ptn/azd/container-apps-stack #3221

Closed
wants to merge 15 commits into from

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 7, 2024

Description

  • Added disclaimer to container-app ptn
  • Regenerated files

Pipeline Reference

Pipeline
avm.ptn.azd.container-apps-stack

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 7, 2024
@AlexanderSehr AlexanderSehr linked an issue Sep 7, 2024 that may be closed by this pull request

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Sep 7, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Needs: Module Owner 📣 This module needs an owner to develop or maintain it Class: Pattern Module 📦 This is a pattern module and removed Needs: Triage 🔍 Maintainers need to triage still labels Sep 7, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 7, 2024 08:22
@AlexanderSehr AlexanderSehr requested review from a team as code owners September 7, 2024 08:22
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 7, 2024 08:22
@AlexanderSehr
Copy link
Contributor Author

Hey @jongio, please review this PR at your earliest convenience so that we can publish the module :)

@matebarabas matebarabas changed the title feat: Added disclaimer to container-app ptn feat: Added disclaimer to container-app ptn - avm/ptn/azd/container-apps Sep 18, 2024
@AlexanderSehr AlexanderSehr marked this pull request as draft October 4, 2024 13:41
@matebarabas matebarabas changed the title feat: Added disclaimer to container-app ptn - avm/ptn/azd/container-apps feat: Added disclaimer to container-app ptn - avm/ptn/azd/container-apps-stack Oct 7, 2024
@matebarabas
Copy link
Contributor

As agreed here, this module has been renamed to avm/ptn/azd/container-apps-stack (formerly, it was avm/ptn/azd/container-apps).

@AlexanderSehr
Copy link
Contributor Author

AlexanderSehr commented Oct 9, 2024

As agreed here, this module has been renamed to avm/ptn/azd/container-apps-stack (formerly, it was avm/ptn/azd/container-apps).

updated.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 9, 2024 07:53
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 9, 2024 07:53
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 9, 2024
Copy link
Contributor

@matebarabas matebarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for incorporating the disclaimer!

@AlexanderSehr
Copy link
Contributor Author

Closing in favor of new #3452

@AlexanderSehr AlexanderSehr deleted the users/alsehr/container-app-disclaimer branch October 9, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.ptn.azd.container-apps
2 participants