Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed use of Gallery-Image SecurityType parameter value 'Standard' and added additional types #3450

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: Fixed use of Gallery-Image SecurityType parameter value 'Standard' and added additional types #3450

merged 1 commit into from
Oct 8, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 8, 2024 •
edited
Loading

Description

  • Fixed use of Gallery-Image SecurityType parameter value 'Standard' ('Standard' should not be set)
  • Added additional types

Pipeline Reference

Pipeline
avm.res.compute.gallery

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 8, 2024
@AlexanderSehr AlexanderSehr self-assigned this Oct 8, 2024
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 8, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 8, 2024 07:45
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 8, 2024 07:45
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 8, 2024 07:45
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 8, 2024
ReneHezser
ReneHezser approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@ReneHezser ReneHezser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @AlexanderSehr

@AlexanderSehr AlexanderSehr merged commit 41479d6 into main Oct 8, 2024
29 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/gallerySecurityType branch October 8, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneHezser ReneHezser ReneHezser approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @ReneHezser