Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update API Version for Compute/SSH-key #3453

Merged
merged 70 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
7ecd1a5
adding deployment files
ChrisSidebotham Oct 12, 2023
0f15c86
ficing rp ref
ChrisSidebotham Oct 12, 2023
c6993a6
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Oct 13, 2023
0e65d72
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Oct 17, 2023
482add6
Adding workflow file
ChrisSidebotham Oct 17, 2023
1bffa61
Merge branch 'Azure:main' into main
ChrisSidebotham Oct 18, 2023
8c358e7
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Oct 18, 2023
14a5d0d
Merge branch 'main' of https://github.com/ChrisSidebotham/bicep-regis…
ChrisSidebotham Oct 18, 2023
fba5375
fixing path
ChrisSidebotham Oct 18, 2023
05152a8
Fixing Workflow name
ChrisSidebotham Oct 18, 2023
f8d04c6
adding workflow
ChrisSidebotham Oct 19, 2023
d22a6c7
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Oct 25, 2023
6993c4d
Adding Workflow file
ChrisSidebotham Oct 25, 2023
cf44304
Adding workflow file
ChrisSidebotham Oct 27, 2023
5260056
Merge branch 'anchor' of https://github.com/ChrisSidebotham/bicep-reg…
ChrisSidebotham Oct 30, 2023
3740075
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Nov 1, 2023
c9b6b4c
Adding workflow file
ChrisSidebotham Nov 1, 2023
a3d83a4
adding workflow
ChrisSidebotham Nov 24, 2023
915d12c
Fixing workflow name
ChrisSidebotham Nov 24, 2023
1c56bb3
update workflow
ChrisSidebotham Nov 30, 2023
454bcc5
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Dec 5, 2023
fe017c1
updating Test Case s location to fix Pipeline
ChrisSidebotham Dec 12, 2023
ddb6e04
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Dec 12, 2023
1931d9a
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Dec 18, 2023
657311c
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Dec 18, 2023
fff3279
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Dec 22, 2023
c5f6e4f
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Dec 22, 2023
ffc5837
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Jan 2, 2024
e9b2e80
adding workflow
ChrisSidebotham Jan 2, 2024
018c016
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Jan 4, 2024
9a3e2bc
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Jan 9, 2024
ebed1d1
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Jan 11, 2024
d587154
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Jan 17, 2024
18a9a54
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Jan 30, 2024
bb9037e
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Jan 30, 2024
de4e665
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Feb 4, 2024
8994eff
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Feb 14, 2024
88df6f6
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Feb 15, 2024
cdfb68d
Adding workflow
ChrisSidebotham Feb 15, 2024
0e3020f
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Feb 28, 2024
40614c1
Update forwardTo property to null if empty
ChrisSidebotham Feb 28, 2024
4240d6c
Update templateHash values in Service Bus Namespace and Topic
ChrisSidebotham Feb 28, 2024
6e16d58
Merge branch 'main' into anchor
ChrisSidebotham Mar 4, 2024
d41dec0
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Mar 4, 2024
689f23d
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Apr 5, 2024
6cd9703
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules
ChrisSidebotham Apr 5, 2024
27de0ec
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Apr 11, 2024
3249154
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Apr 12, 2024
65802d0
Merge branch 'Azure:main' into anchor
ChrisSidebotham May 8, 2024
8a0d70b
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham May 21, 2024
e19c970
Merge branch 'Azure:main' into main
ChrisSidebotham May 21, 2024
dc5e12d
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham May 22, 2024
379534f
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham May 22, 2024
77e2f8c
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham May 23, 2024
6e0b216
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham May 24, 2024
e4cf2a0
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham May 29, 2024
bacee7d
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Jun 12, 2024
e8c9b85
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Jun 26, 2024
4ca1290
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Aug 1, 2024
3211b7c
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Aug 13, 2024
bb507f9
#2578
ChrisSidebotham Aug 13, 2024
7ec58b0
typo
ChrisSidebotham Aug 13, 2024
88d09f1
typo
ChrisSidebotham Aug 13, 2024
0a7cefc
Merge branch 'main' of https://github.com/Azure/bicep-registry-module…
ChrisSidebotham Sep 6, 2024
64d7206
Merge branch 'anchor' of https://github.com/ChrisSidebotham/bicep-reg…
ChrisSidebotham Sep 6, 2024
ff6facc
Adding logic to skip for non resource modules
ChrisSidebotham Sep 6, 2024
d0dadd0
chore: Remove trailing whitespace in main.json file
ChrisSidebotham Sep 6, 2024
77014ff
Merge branch 'anchor' of https://github.com/ChrisSidebotham/bicep-reg…
ChrisSidebotham Oct 8, 2024
99c519f
fix: Update Microsoft.Compute/sshPublicKeys API version to 2024-03-01
ChrisSidebotham Oct 8, 2024
9c1ee47
Merge branch 'main' into ssh-key-update
ChrisSidebotham Oct 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion avm/res/compute/ssh-public-key/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This module deploys a Public SSH Key.
| :-- | :-- |
| `Microsoft.Authorization/locks` | [2020-05-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2020-05-01/locks) |
| `Microsoft.Authorization/roleAssignments` | [2022-04-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2022-04-01/roleAssignments) |
| `Microsoft.Compute/sshPublicKeys` | [2023-07-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Compute/2023-07-01/sshPublicKeys) |
| `Microsoft.Compute/sshPublicKeys` | [2024-03-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Compute/2024-03-01/sshPublicKeys) |

## Usage examples

Expand Down
2 changes: 1 addition & 1 deletion avm/res/compute/ssh-public-key/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ resource avmTelemetry 'Microsoft.Resources/deployments@2024-03-01' = if (enableT
}
}

resource sshPublicKey 'Microsoft.Compute/sshPublicKeys@2023-07-01' = {
AlexanderSehr marked this conversation as resolved.
Show resolved Hide resolved
resource sshPublicKey 'Microsoft.Compute/sshPublicKeys@2024-03-01' = {
name: name
location: location
tags: tags
Expand Down
8 changes: 4 additions & 4 deletions avm/res/compute/ssh-public-key/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "8431280172894888036"
"version": "0.30.23.60470",
"templateHash": "5428269336337327866"
},
"name": "Public SSH Keys",
"description": "This module deploys a Public SSH Key.\n\n> Note: The resource does not auto-generate the key for you.",
Expand Down Expand Up @@ -199,7 +199,7 @@
},
"sshPublicKey": {
"type": "Microsoft.Compute/sshPublicKeys",
"apiVersion": "2023-07-01",
"apiVersion": "2024-03-01",
"name": "[parameters('name')]",
"location": "[parameters('location')]",
"tags": "[parameters('tags')]",
Expand Down Expand Up @@ -271,7 +271,7 @@
"metadata": {
"description": "The location the resource was deployed into."
},
"value": "[reference('sshPublicKey', '2023-07-01', 'full').location]"
"value": "[reference('sshPublicKey', '2024-03-01', 'full').location]"
}
}
}