Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ORPHANED Vnet Module #3492

Merged
merged 6 commits into from
Oct 11, 2024
Merged

docs: ORPHANED Vnet Module #3492

merged 6 commits into from
Oct 11, 2024

Conversation

elbatane
Copy link
Contributor

@elbatane elbatane commented Oct 9, 2024 •
edited
Loading

Description

VNET module Orphaned

Pipeline Reference

Pipeline
avm.res.network.virtual-network

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@elbatane elbatane requested review from a team as code owners October 9, 2024 09:00
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 9, 2024
@elbatane elbatane changed the title ORPHANED Vnet Module [docs] ORPHANED Vnet Module Oct 9, 2024
@elbatane elbatane changed the title [docs] ORPHANED Vnet Module docs: ORPHANED Vnet Module Oct 9, 2024
eriqua
eriqua reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💔

@eriqua eriqua added Class: Resource Module 📦 This is a resource module Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 9, 2024
eriqua
eriqua approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua removed the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Oct 10, 2024
@eriqua eriqua merged commit 5962284 into main Oct 11, 2024
6 checks passed
@eriqua eriqua deleted the users/elbatane/vnet_orphan branch October 11, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@elbatane elbatane

@eriqua eriqua

Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elbatane @eriqua @elenabatanero