Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Container-App-Stack - Trigger publish #3497

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 9, 2024

Description

  • Just a small change to ensure the module is published as a previous merge did not do the trick
  • Also added missing passthru of enableTelemetry parameter to this and the insights-dashboard module

@AlexanderSehr AlexanderSehr requested review from a team as code owners October 9, 2024 19:46
@AlexanderSehr AlexanderSehr self-assigned this Oct 9, 2024
@AlexanderSehr AlexanderSehr added the Class: Pattern Module 📦 This is a pattern module label Oct 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 9, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 9, 2024
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner October 9, 2024 19:58
Copy link
Contributor

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jtracey93 jtracey93 merged commit d0cbe01 into main Oct 10, 2024
5 checks passed
@jtracey93 jtracey93 deleted the users/alsehr/triggerContainerAppStack branch October 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants