Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Aligned AKS interface to AVM specs & added UDT #3506

Merged
merged 16 commits into from
Oct 14, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Aligned AKS interface to AVM specs
  • Added UDT & mapping for primary agent pool

Depending on #3228

Pipeline Reference

Pipeline
avm.res.container-service.managed-cluster

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Oct 10, 2024
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working Class: Resource Module 📦 This is a resource module labels Oct 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 10, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 10, 2024
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Oct 10, 2024
@tsc-buddy
Copy link
Contributor

@AlexanderSehr - what are your thoughts on defaulting this to use 3 AZs by default rather than just declared in the tests?

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr - what are your thoughts on defaulting this to use 3 AZs by default rather than just declared in the tests?

Hey @tsc-buddy, good call. As per the corresponding spec, this should be the default anyways.

@AlexanderSehr AlexanderSehr linked an issue Oct 12, 2024 that may be closed by this pull request
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 13, 2024 13:32
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 13, 2024 13:32
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 13, 2024 13:32
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 13, 2024
Copy link
Contributor

@JPEasier JPEasier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfekt!

Please update your branch with the latest changes and rerun the pipline.

@AlexanderSehr AlexanderSehr merged commit b420117 into main Oct 14, 2024
17 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/containerServiceInterfaceFix branch October 14, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants