Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Trigger azd ml project publishing #3511

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: Trigger azd ml project publishing #3511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adcc528
issue template order
eriqua Oct 11, 2024
29b2697
small update to trigger publishing
eriqua Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/avm_module_issue.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ body:
- "avm/ptn/azd/apim-api"
- "avm/ptn/azd/container-apps-stack"
- "avm/ptn/azd/insights-dashboard"
- "avm/ptn/azd/ml-project"
- "avm/ptn/azd/ml-hub-dependencies"
- "avm/ptn/azd/ml-project"
- "avm/ptn/azd/monitoring"
- "avm/ptn/deployment-script/import-image-to-acr"
- "avm/ptn/dev-ops/cicd-agents-and-runners"
Expand Down
4 changes: 2 additions & 2 deletions avm/ptn/azd/ml-project/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ param location = '<location>'
| [`projectKind`](#parameter-projectkind) | string | The type of Azure Machine Learning workspace to create. |
| [`projectManagedIdentities`](#parameter-projectmanagedidentities) | object | The managed identity definition for the machine learning resource. At least one identity type is required. |
| [`projectSku`](#parameter-projectsku) | string | Specifies the SKU, also referred as 'edition' of the Azure Machine Learning workspace. |
| [`publicNetworkAccess`](#parameter-publicnetworkaccess) | string | Whether or not public network access is allowed for this machine learning resource. For security reasons it should be disabled. |
| [`publicNetworkAccess`](#parameter-publicnetworkaccess) | string | Whether or not public network access is allowed for this machine learning workspace. For security reasons it should be disabled. |
| [`roleDefinitionIdOrName`](#parameter-roledefinitionidorname) | array | The role to assign. You can provide either the display name of the role definition, the role definition GUID, or its fully qualified ID in the following format: '/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11'. Default roles: AzureML Data Scientist, Azure Machine Learning Workspace Connection Secrets Reader. |
| [`tags`](#parameter-tags) | object | Tags of the resource. |

Expand Down Expand Up @@ -268,7 +268,7 @@ Specifies the SKU, also referred as 'edition' of the Azure Machine Learning work

### Parameter: `publicNetworkAccess`

Whether or not public network access is allowed for this machine learning resource. For security reasons it should be disabled.
Whether or not public network access is allowed for this machine learning workspace. For security reasons it should be disabled.

- Required: No
- Type: string
Expand Down
5 changes: 2 additions & 3 deletions avm/ptn/azd/ml-project/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ param projectKind string = 'Project'
@description('Optional. The flag to signal HBI data in the workspace and reduce diagnostic data collected by the service.')
param hbiWorkspace bool = false

@description('Optional. Whether or not public network access is allowed for this machine learning resource. For security reasons it should be disabled.')
@description('Optional. Whether or not public network access is allowed for this machine learning workspace. For security reasons it should be disabled.')
@allowed([
'Enabled'
'Disabled'
Expand Down Expand Up @@ -121,7 +121,7 @@ module keyVaultAccess 'br/public:avm/res/key-vault/vault:0.9.0' = {
accessPolicies: [
{
objectId: project.outputs.systemAssignedMIPrincipalId
permissions: { secrets: [ 'get', 'list' ] }
permissions: { secrets: ['get', 'list'] }
}
]
enableTelemetry: enableTelemetry
Expand Down Expand Up @@ -171,4 +171,3 @@ type managedIdentitiesType = {
@description('Optional. The resource ID(s) to assign to the resource.')
userAssignedResourceIds: string[]?
}

4 changes: 2 additions & 2 deletions avm/ptn/azd/ml-project/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"_generator": {
"name": "bicep",
"version": "0.30.23.60470",
"templateHash": "12979908494001456774"
"templateHash": "15406074241490987266"
},
"name": "Azd Machine Learning workspace",
"description": "Create a machine learning workspace, configure the key vault access policy and assign role permissions to the machine learning instance.\n\n**Note:** This module is not intended for broad, generic use, as it was designed to cater for the requirements of the AZD CLI product. Feature requests and bug fix requests are welcome if they support the development of the AZD CLI but may not be incorporated if they aim to make this module more generic than what it needs to be for its primary use case.",
Expand Down Expand Up @@ -106,7 +106,7 @@
"Disabled"
],
"metadata": {
"description": "Optional. Whether or not public network access is allowed for this machine learning resource. For security reasons it should be disabled."
"description": "Optional. Whether or not public network access is allowed for this machine learning workspace. For security reasons it should be disabled."
}
},
"hubResourceId": {
Expand Down
Loading