Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding rules for subscriptions in avm/res/service-bus/namespace #3558

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

timdhaeyer
Copy link

Description

Adding rules for subscriptions in avm/res/service-bus/namespace

Pipeline Reference

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@timdhaeyer
Copy link
Author

@microsoft-github-policy-service agree company="Zure"

@ChrisSidebotham
Copy link
Contributor

Hey @timdhaeyer - This looks promising, I believe you also used the helper script. can you update the readme by running the set-avmmodule toolset as described here: https://azure.github.io/Azure-Verified-Modules/contributing/bicep/bicep-contribution-flow/generate-bicep-module-files/

Then run the workflow to test the new configuration in your subscription?

@timdhaeyer
Copy link
Author

@ChrisSidebotham I have done what you requested. I added a test file that just creates a single rule inside a subscription. You can find it under the test files. Is this ok for you? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Question/Feedback]: servicebus/namespace/topics/subcriptions/rules not availble?
2 participants