Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: do not count context errors as failure to renew a lock #212

Closed
wants to merge 2 commits into from

Conversation

serbrech
Copy link
Member

@serbrech serbrech commented Apr 8, 2024

fixes #211

@coveralls
Copy link
Collaborator

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 8595365308

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 85.204%

Totals Coverage Status
Change from base Build 8595162956: 0.6%
Covered Lines: 668
Relevant Lines: 784

💛 - Coveralls

@serbrech serbrech changed the title Do not count context errors as failure to renew a lock 🐛 fix: Do not count context errors as failure to renew a lock Apr 8, 2024
@serbrech serbrech changed the title 🐛 fix: Do not count context errors as failure to renew a lock 🐛 fix: do not count context errors as failure to renew a lock Apr 8, 2024
@serbrech serbrech marked this pull request as draft April 8, 2024 23:21
@serbrech serbrech marked this pull request as ready for review April 8, 2024 23:22
@serbrech serbrech closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition in /v2/lockrenewer.go causes unnecessary increment of MessageLockRenewedFailure counter
2 participants