Add debug symbols to packages #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before vs. after sizes of debug packages for all the distros/architectures we build: |
arsing
approved these changes
Feb 7, 2024
damonbarry
added a commit
to damonbarry/iot-identity-service
that referenced
this pull request
Feb 7, 2024
Currently, we provide symbol packages for all the distros we build, with the exception of Mariner (disabled due to a rust issue, then never reverted). However, the packages don't contain our symbols because we instruct rustc to build the release configuration, which doesn't emit debug information by default. This change updates Cargo.toml to enable full debug information in release builds. It also reverts the config that was supressing symbol packages in Mariner. The deb/rpm packaging tools already strip symbols from release binaries and generate symbol packages, so no further changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we provide symbol packages for all the distros we build, with the exception of Mariner (disabled due to a rust issue, then never reverted). However, the packages don't contain our symbols because we instruct rustc to build the release configuration, which doesn't emit debug information by default.
This change updates Cargo.toml to enable full debug information in release builds. It also reverts the config that was supressing symbol packages in Mariner. The deb/rpm packaging tools already strip symbols from release binaries and generate symbol packages, so no further changes are needed.