Add new methods to extract fields in PartitionLoadInformation #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
reviewed
Oct 29, 2024
| pub fn primary_load_metric_reports(&self) -> Vec<LoadMetricReport> { | ||
| self | ||
| .primary_load_metric_reports | ||
| .iter() |
There was a problem hiding this comment.
Just return the PrimaryLoadMetricReportList. make the field private.
mssf api prefers not use Vec or other types that requires dynamic alloc for list.
|
In that case, probably for simplicity we can stick with the current implementation. Just treating the struct as a C-style struct with public members. Closed the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.