-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node_pools
to outputs
#401
base: main
Are you sure you want to change the base?
Conversation
Hello @SubatomicHero , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SubatomicHero for opening this pr! We don't encourage outputting resource directly in the module, I've checked data.azurerm_kubernetes_cluster_node_pool
and all it requires is cluster name, pool name and resource group name.
Could we only output the pools' names like this?:
output "pool_name" {
value = { for k, p in azurerm_kubernetes_cluster_node_pool.node_pool : k => p.name }
}
@lonegunmanb sorry for the late reply. That's been done and I agree with your change! This is now ready to review again @zioproto the use case is so that we can run our terraform test assertions making sure the extra node pool is configured a certain way. We need access to the azurerm_kubernetes_cluster_node_pool.node_pool output to allow this. |
@zioproto is there anything else this PR is waiting on to progress? I've taken over since the PR owner has since left our organisation so won't be contributing to it. |
@fleetwoodstack LGTM. I don't have ownership over this repo to merge the PR. Friendly ping to @lonegunmanb to approve the CI workflow and eventually merge :) Thanks |
@lonegunmanb are you OK to mark your requested changes as having been done? I don't own this PR sadly to be able to mark them as completed. |
@lonegunmanb When you get a moment, this is ready to merge |
Describe your changes
This change adds the
node_pools
created withvar.node_pools
to the outputs. Useful for local testing of the moduleChecklist before requesting a review
CHANGELOG.md
file