Amend new attributes in network_profile block #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zioproto
reviewed
Aug 20, 2024
main.tf
Outdated
| service_cidr = var.net_profile_service_cidr | ||
| service_cidrs = var.network_service_cidrs |
There was a problem hiding this comment.
Same here, it would be either service_cidr or service_cidrs.
There was a problem hiding this comment.
I've verified that we could set both service_cidr and service_cidrs @zioproto , here's my tfstate snippet:
"pod_cidr": "10.244.0.0/16",
"pod_cidrs": [
"10.244.0.0/16",
"fded:4c8d:9691:939b::/64"
],
"service_cidr": "10.0.0.0/16",
"service_cidrs": [
"10.0.0.0/16",
"fd01:db8:deca::/108"
]
zioproto
reviewed
Aug 23, 2024
| description = "(Optional) Specifies the data plane used for building the Kubernetes network. Possible values are `azure` and `cilium`. Defaults to `azure`. Disabling this forces a new resource to be created." | ||
| } | ||
|
|
||
| variable "network_ip_versions" { |
There was a problem hiding this comment.
We need a precondition that network_plugin_mode is set to overlay
zioproto
reviewed
Sep 5, 2024
| default = null | ||
| description = <<-EOT | ||
| `nat_gateway_profile` block supports the following: | ||
| - `idle_timeout_in_minutes` - (Optional) Desired outbound flow idle timeout in minutes for the cluster load balancer. Must be between `4` and `120` inclusive. Defaults to `4`. |
There was a problem hiding this comment.
Doing a review of this PR I found out that the upstream provider documentation was wrong. Also for the parameters.
I opened a PR here:
https://github.com/hashicorp/terraform-provider-azurerm/pull/27287/files
zioproto
reviewed
Oct 4, 2024
| default = null | ||
| description = <<-EOT | ||
| `nat_gateway_profile` block supports the following: | ||
| - `idle_timeout_in_minutes` - (Optional) Desired outbound flow idle timeout in minutes for the cluster load balancer. Must be between `4` and `120` inclusive. Defaults to `4`. |
There was a problem hiding this comment.
Suggested change
| - `idle_timeout_in_minutes` - (Optional) Desired outbound flow idle timeout in minutes for the cluster load balancer. Must be between `4` and `120` inclusive. Defaults to `4`. | |
| - `idle_timeout_in_minutes` - (Optional) Desired outbound flow idle timeout in minutes for the managed nat gateway. Must be between `4` and `120` inclusive. Defaults to `4`. |
There was a problem hiding this comment.
@lonegunmanb please review suggestion
zioproto
reviewed
Oct 4, 2024
| description = <<-EOT | ||
| `nat_gateway_profile` block supports the following: | ||
| - `idle_timeout_in_minutes` - (Optional) Desired outbound flow idle timeout in minutes for the cluster load balancer. Must be between `4` and `120` inclusive. Defaults to `4`. | ||
| - `managed_outbound_ip_count` - (Optional) Count of desired managed outbound IPs for the cluster load balancer. Must be between `1` and `100` inclusive. |
There was a problem hiding this comment.
Suggested change
| - `managed_outbound_ip_count` - (Optional) Count of desired managed outbound IPs for the cluster load balancer. Must be between `1` and `100` inclusive. | |
| - `managed_outbound_ip_count` - (Optional) Count of desired managed outbound IPs for the managed nat gateway. Must be between `1` and `16` inclusive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pr amended missing new attributes in
network_profilenested block.It doesn't support
outbound_ip_prefix_idsandoutbound_ip_address_idssince they're about to be deprecated in AzureRM providerv4.Issue number
#518
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!