Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix javadoc build voor bag2 loader #1602

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix javadoc build voor bag2 loader #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f8c8d
Fix javadoc build voor bag2 loader
mprins Nov 29, 2022
03e5827
Update linux.yml
mprins Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
# downgrade to 11 because javadoc bug https://bugs.openjdk.org/browse/JDK-8222091
# see https://github.com/B3Partners/brmo/pull/1602
java-version: '11.0.16'
java-version: 11
cache: 'maven'
# this check can be removed when GH runners update to Javan 11.0.18 or higher
check-latest: true

- name: 'Javadoc'
run: mvn compile javadoc:javadoc -DskipQA=true
Expand Down
1 change: 1 addition & 0 deletions bag2-loader/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ SPDX-License-Identifier: MIT
<generatePackage>nl.b3p.brmo.bag2.xml.leveringsdocument</generatePackage>
<schemaDirectory>${project.basedir}/src/main/xsd/</schemaDirectory>
<schemaIncludes>**/*.xsd</schemaIncludes>
<markGenerated>true</markGenerated>
</configuration>
<executions>
<execution>
Expand Down
2 changes: 0 additions & 2 deletions brmo-commandline/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
<artifactId>commons-cli</artifactId>
</dependency>
<dependency>
<!-- deze is eigenlijk alleen nodig voor java 11, maar
omdat we een runnable jar met classpath maken makkelijk om ook voor java 8 er bij te stoppen -->
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
<version>${jaxb.api.version}</version>
Expand Down
5 changes: 3 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,7 @@
<show>package</show>
<useStandardDocletOptions>true</useStandardDocletOptions>
<links>
<link>https://docs.oracle.com/en/java/javase/11/docs/api/</link>
<link>https://www.slf4j.org/apidocs/</link>
<link>https://docs.oracle.com/javaee/7/api/</link>
<link>https://docs.jboss.org/hibernate/orm/5.6/javadocs/</link>
Expand All @@ -1000,11 +1001,11 @@
<link>https://junit.org/junit5/docs/current/api/</link>
<link>https://b3partners.github.io/kadaster-gds2/apidocs/</link>
<link>https://b3partners.github.io/jdbc-util/apidocs/</link>
<link>https://jdbc.postgresql.org/documentation/publicapi/</link>
<link>https://www.xmlunit.org/api/java/main/</link>
</links>
<encoding>${project.build.sourceEncoding}</encoding>
<packagesheader>${project.artifactId}</packagesheader>
<!-- dit werkt niet voor veel projecten omdat de detected-link ${project.url}/apidocs is -->
<detectLinks>false</detectLinks>
<tags>
<tag>
<name>todo</name>
Expand Down