feat: use onPromiseClick

BBN-Holding · Jan 21, 2024 · b63e10f · b63e10f
1 parent b1ff331
commit b63e10f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/pages/admin/dialog.ts b/pages/admin/dialog.ts
@@ -86,7 +86,7 @@ export const ApproveDialog = SheetDialog(sheetStack, "Approve Drop",
                         : Empty()).asRefComponent()),
                     Spacer(),
                     Button("Cancel").setStyle(ButtonStyle.Secondary).onClick(() => ApproveDialog.close()),
-                    Button("Submit").onClick(async () => {
+                    Button("Submit").onPromiseClick(async () => {
                         const { data, error, validate } = Validate(
                             dialogState,
                             zod.object({
@@ -95,7 +95,10 @@ export const ApproveDialog = SheetDialog(sheetStack, "Approve Drop",
                         );
 
                         validate();
-                        if (error.getValue()) return data.validationState = error.getValue();
+                        if (error.getValue()) {
+                            data.validationState = error.getValue();
+                            return;
+                        };
 
                         await API.music.id(drop._id).review.post({
                             title: dropPatternMatching(reviewTexts.APPROVED.header, drop),
@@ -207,7 +210,7 @@ export const DeclineDialog = SheetDialog(sheetStack, "Decline Drop",
                         : Empty()).asRefComponent()),
                     Spacer(),
                     Button("Cancel").setStyle(ButtonStyle.Secondary).onClick(() => DeclineDialog.close()),
-                    Button("Submit").onClick(async () => {
+                    Button("Submit").onPromiseClick(async () => {
                         const { error, validate } = Validate(
                             rejectState,
                             zod.object({
@@ -216,7 +219,10 @@ export const DeclineDialog = SheetDialog(sheetStack, "Decline Drop",
                         );
 
                         validate();
-                        if (error.getValue()) return dialogState.validationState = error.getValue();
+                        if (error.getValue()) {
+                            dialogState.validationState = error.getValue();
+                            return;
+                        }
 
                         const reason = <ReviewResponse[]>rejectState.respones;
 

diff --git a/pages/admin/views/entryReview.ts b/pages/admin/views/entryReview.ts
@@ -27,8 +27,8 @@ export const changeTypeDialog = SheetDialog(sheetStack, "Change Drop Type",
         DropDownInput("Change Type", Object.values(DropType)).sync(changeState, "type"),
         Horizontal(
             Spacer(),
-            Button("Change").onClick(() => {
-                API.music.id(changeState.drop!._id).type.post(changeState.type!);
+            Button("Change").onPromiseClick(async () => {
+                await API.music.id(changeState.drop!._id).type.post(changeState.type!);
                 changeTypeDialog.close();
             })
         )