Fix build for big endian AArch64 hosts #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation does not support using arm neon on big-endian hosts: see blake3_neon.c. Setting `BLAKE3_USE_NEON` to 1 by default for all AArch64 hosts broke builds for big endian hosts. This patch fixes the behavior by introducing an additional check against `__ARM_BIG_ENDIAN` before setting `BLAKE3_USE_NEON`.
|
I happened to get to #280 before this PR, but feel to rebase this and make it cleanup if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation does not support using arm neon on big-endian hosts: see blake3_neon.c. Setting
BLAKE3_USE_NEONto 1 by default for all AArch64 hosts broke builds for big endian hosts. This patch fixes the behavior by introducing an additional check against__ARM_BIG_ENDIANbefore settingBLAKE3_USE_NEON.