Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde support for Hash behind optional feature #339

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

rminderhoud
Copy link
Contributor

Added a new cargo feature serde that when enabled will derive serde::Serialize and serde::Deserialize for the blake3::Hash struct.

Fixes #290

Cargo.toml Outdated Show resolved Hide resolved
@oconnor663
Copy link
Member

Lots of folks have asked for this over the last couple years, so it probably does make sense to go ahead and include it. Thanks for opening the PR!

@rminderhoud
Copy link
Contributor Author

Lots of folks have asked for this over the last couple years, so it probably does make sense to go ahead and include it. Thanks for opening the PR!

Thanks, I'm glad you are willing to merge it into main!

@oconnor663
Copy link
Member

Could you rebase on the most recent master? There has been some churn in Cargo.toml.

Added a new cargo feature `serde` that when enabled will derive
`serde::Serialize` and `serde::Deserialize` for the `blake3::Hash`
struct.
@rminderhoud
Copy link
Contributor Author

Sure no problem, rebased with latest master branch

@oconnor663 oconnor663 merged commit 5e3eb94 into BLAKE3-team:master Sep 20, 2023
50 checks passed
@oconnor663
Copy link
Member

Landed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide optional serde support for blake3::Hash
2 participants