Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove portal-vue and vuejs-dialog as dependencies since COSMOS remov… #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mteckes
Copy link

@mteckes mteckes commented Jul 26, 2022

Looks like COSMOS past 5.0.1 removed portal-vue and vuejs-dialog. Since these are gone, planetviewer cannot load because it is looking for those dependencies.

  1. Remove portal-vue
  2. Remove vuejs-dialog

The following commits removed these dependencies from COSMOS

remove vuuejs-dialog as external
remove portal-vue as external

I would get the following errors:

Uncaught Error: application '@cosmosc2/tool-planetviewer' died in status LOADING_SOURCE_CODE: Unable to resolve bare specifier 'portal-vue' from http://cosmos-002:2900/tools/planetviewer/js/app.js (SystemJS Error#8 https://git.io/JvFET#8)
    resolve http://cosmos-002:2900/js/system-6.12.1.min.js:1
    resolve http://cosmos-002:2900/js/system-6.12.1.min.js:1
    resolve http://cosmos-002:2900/js/named-register.min.js:1
    c http://cosmos-002:2900/js/system-6.12.1.min.js:1
    c http://cosmos-002:2900/js/system-6.12.1.min.js:1
system-6.12.1.min.js:1:7801
    resolve http://cosmos-002:2900/js/system-6.12.1.min.js:1
    resolve http://cosmos-002:2900/js/system-6.12.1.min.js:1
    resolve http://cosmos-002:2900/js/named-register.min.js:1
    c http://cosmos-002:2900/js/system-6.12.1.min.js:1
    map self-hosted:218
    c http://cosmos-002:2900/js/system-6.12.1.min.js:1

and I also get this error:

    Uncaught Error: application '@cosmosc2/tool-planetviewer' died in status LOADING_SOURCE_CODE: application '@cosmosc2/tool-planetviewer' died in status LOADING_SOURCE_CODE: Unable to resolve bare specifier 'portal-vue' from http://cosmos-002:2900/tools/planetviewer/js/app.js (SystemJS Error#8 https://git.io/JvFET#8)
    resolve http://cosmos-002:2900/js/system-6.12.1.min.js:1
    resolve http://cosmos-002:2900/js/system-6.12.1.min.js:1
    resolve http://cosmos-002:2900/js/named-register.min.js:1
    c http://cosmos-002:2900/js/system-6.12.1.min.js:1
    c http://cosmos-002:2900/js/system-6.12.1.min.js:1

I removed portal-vue and vuejs-dialog, built with the following commands in a virtual environment:

yarn
...
yarn build
...
rake build VERSION=5.0.5

Once built, I uploaded the GEM to COSMOS 5.0.5 in the admin tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant