Webhooks support. #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored PR structs to carry the original request and its headers.
|
@danielgomezrico plz review! |
| @@ -50,10 +50,10 @@ func TestLoadConfig(t *testing.T) { | |||
| assert.Ok(t, err) | |||
| defer os.Remove(configPath) | |||
|
|
|||
| config, err := Load(configPath) | |||
| loadedConf, err := Load(configPath) | |||
There was a problem hiding this comment.
+1 to name it loadedConfig instead of loadedConf
| } | ||
|
|
||
| // NormalizePRPayload turns a bitbucket-specific PR payload into a general one. | ||
| func NormalizePRPayload(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| pr := new(PullRequest) |
There was a problem hiding this comment.
A PullRequest is nothing if is not Hidrated?
if so why not add some build static functions to create a new pull request from the PullRequest instead?
- PullRequest.fromBitbucket(request)
- PullRequest.fromGithub(request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.