Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor jboss completion #1837

Merged
merged 3 commits into from
Apr 26, 2021
Merged

vendor jboss completion #1837

merged 3 commits into from
Apr 26, 2021

Conversation

NoahGorny
Copy link
Member

Description

Add jboss completion as a vendored dependency

Motivation and Context

#1818

How Has This Been Tested?

I just tested to see if the completion is loaded, I did not test the completion itself

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Noah Gorny added 3 commits February 13, 2021 10:34
Squashed 'vendor/github.com/rparree/jboss-bash-completion/' content f…
e89948a 
…rom commit fc87d94

git-subtree-dir: vendor/github.com/rparree/jboss-bash-completion
git-subtree-split: fc87d94e7da9431133190f60f5a84367e44d650c
Add "jboss-completion" from "https://github.com/rparree/jboss-bash-co…
a30a769 
…mpletion@master"

git-vendor-name: jboss-completion
git-vendor-dir: vendor/github.com/rparree/jboss-bash-completion
git-vendor-repository: https://github.com/rparree/jboss-bash-completion
git-vendor-ref: master
completion: Use vendored jboss completion
64d827c 
Also include new jboss5 vendored completion
@NoahGorny
Copy link
Member Author

hey @cornfeedhobo, can you take a look?

davidpfarrell
davidpfarrell approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this looks pretty legit to me.

I'm definitely a fan of our vendor feature for storing third-party files, but I'm wondering if we should have some kind of README-BASHIT file that can accompany the vendored files, that gives information about where the original files live and maybe which version of the file we've included, etc?

@NoahGorny
Copy link
Member Author

So this looks pretty legit to me.

I'm definitely a fan of our vendor feature for storing third-party files, but I'm wondering if we should have some kind of README-BASHIT file that can accompany the vendored files, that gives information about where the original files live and maybe which version of the file we've included, etc?

They best way to do this would be to use git vendor, which is the tool used to vendor these dependencies. If you run git vendor list in the repo you will get this exact information 😄

@NoahGorny NoahGorny merged commit d3bb347 into Bash-it:master Apr 26, 2021
@NoahGorny NoahGorny deleted the vendor-jboss-completion branch April 26, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpfarrell davidpfarrell davidpfarrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoahGorny @davidpfarrell