-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta #10
Open
martingebel
wants to merge
85
commits into
main
Choose a base branch
from
beta
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Beta #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add download as csv button -Add filter
-remove collapse panel 'advanced settings' -add parameter 'effect'/'strat' and 'subgroup' to the effect_calc() calculation
…tion -add warning text for all csv file inputs
-increase max upload size from 40 to 100MB app_ui.R: -Change version date mod_data_manual: -change text of maximal file size fct_effect_calc.R: -change if-conditions for subgroup and strata -add suppressWarnings for rma.mh functions mod_file_creation.R: -add checkboxInputs for subgroup and stratification variables and add reactiveValues subgroup_reac_val & stratificiation_reac_val for effect_calc function -change option multiple = FALSE for pickerInput "effect"
change choices to fit functtion effect_calc fct_effect_calc.R: update to recent version fct_effect_calc_test.R: update vectorized version
add downloadhandler functionality
-add parameter aval for analysis value mod_file_creation.R: -add selecitonInput "sel_aval" for analysis value -allow multiple selections in stratification selection
-add supressWarningsmessages mod_file_creation.R: -add isTruthy-function - set multiple = FALSE for stratification variable
Bug fix: check if selected population variable is numeric in data
-add "Check"-text for variable analysis set -add 'Click to open' text -remove "Required variables in ADTTE" text in start text -add ITT and FAS to analysis set character string for analysis set variable selection fct_effect_calc.R: - bug fix for numeric variable population
- update to most recent version mod_file_creation.R: - create new button panel - change choices in effect Input in File creation
change stratification pickerinput to multiple true
- fix bug strata variable mod_file_creation.R: -change choices of data_scope
-add day variable in file creation for methods "CID" and "EXCESS_CID" -add Intro text -remove text from image tag -remove server option fct_effect_calc.R: -add most recent version of the function app_ui: -remove text from image tag app_server: -change Intro text
-bug in effect == "HR" for multiple verum selections mod_file_creation.R: -add day_variable_check to observer for calculation button color
-increase upload size
app_server.R: bug fix: "Upload Data"
app_server.R: -fix sorting "As Input" in forestplot fct_effect_calc_new.R: -change text for EXCESS_CID and CID for 2-level events
bug fix: Change missings to "." instead of NA to avoid getting character values in read.csv
add new arrangement method to debug missing/incorrect subgroup selection
-Set missing subgroups to "N/A" in effect_calc_new - remove filter t_1 >0 & t_2>0 since this remove subgroups with 0 events in one of the treatement groups
undo changes from version 2.0.8
Addition of documentation in rd_func For CID create NAs in case of zero cell counts and missing patients in one treatment group
…ESS_CID & CID Adaption for this data situation still needed for HR
… EXCESS_CID & CID
Further clarification on methodology added to about BReasy and data manual tabs
app_server.R: (Only) If 'file creation'-tab is used, transform Estimates in percent for ARD, IRD and CID for Forest Plot display fct_effect_calc_new.R: -Change 100 patient years to patient years and correct calculations
app_server: -expand required variable list for "EXCESS_XX" and check if EFFECT_XX or EXCESSS_XX is available fct_breasy_forestplot.R: -add EXCESS_ as possible Estimate name fct_effect_calc_new.R: -rename variable from EFFECT_XX to EXCESS_XX when EXCESS method is selected in file_creation tab
Bug fix in effect_calc_new-function: Calculate effect * 10000 for excess number first and then use round(3)
fct_breasy_forestplot.R: -Change forest plot x-axis label
…evtools::check() remove old effect_calc-function
Allowing the calculation of estimates based on cumulative incidences in case of zero cell counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update main based on beta branch including file creation