Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIRAX fixture #54

Closed

Conversation

GuillaumeDesforges
Copy link

@GuillaumeDesforges GuillaumeDesforges commented Jan 5, 2023

The MIRAX fixture marks test with the "mirax" marker. By default all MIRAX tests are skipped. To enable a MIRAX test, add a "support_mirax" marker to a test.

Follow-up on #44 (comment)

I would suggest to continue by adding a test_mirax.py file with tests for locally stored mirax files. They should all be available publicly, so that everyone can reproduce behaviour.

The MIRAX fixture marks test with the "mirax" marker. By default all
MIRAX tests are skipped. To enable a MIRAX test, add a "support_mirax"
marker to a test.
@GuillaumeDesforges GuillaumeDesforges mentioned this pull request Jan 5, 2023
3 tasks
Copy link
Collaborator

@ap-- ap-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please configure pyproject.toml to not run the mirax tests by default.

# pyproject.toml
[tool.pytest.ini_options]
addopts = [
  "-v",
  # (only needed by windows) disable faulthandler plugin to suppress non-fatal error msgs
  "-p", "no:faulthandler",
  "-m", "not compat",
  "-m", "not mirax",
  "--strict-markers"
]
markers = [
  "mirax",
  "support_mirax",
  "compat",
]

@ap--
Copy link
Collaborator

ap-- commented Jan 6, 2023

Hi Guillaume,

I'm a bit worried about the ~500Mb download that would happen by default when running the test suite.

Could you configure pytest to skip mirax tests by default and require to explicitly provide the mirax marker to run the supported tests? pytest -m mirax

We would then run the mirax tests locally for now and not in the CI and come up with a good solution for loading CMU-1.zip for CI tests.

There's other places where we could load it from if we need more frequent mirax testing (i.e. https://gist.github.com/ap--/4143a86a73b83f717555cb88aa2dd96e). I'd almost prefer if we could just generate our own minimal mirax file or find one with the right license and a size <= 10Mb or so...

Cheers,
Andreas 😃

@GuillaumeDesforges
Copy link
Author

Sorry, I am not working on MIRAX anymore and have had to put that on the side for the time being 😞 I'll get back to it when I get some time, but I can't garantee I ever will...

@ap--
Copy link
Collaborator

ap-- commented Apr 15, 2023

No worries 😃
Thanks for the update.

I'll close this PR then for now. If at any future point in time you might revisit feel free to reopen.

Also, in case you have any insights or details about problems you ran into, it would be awesome if you could add that information to #44

Cheers,
Andreas 😊

@ap-- ap-- closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants