Mid april24 midmay24 updates #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes (Resolves superlistapp#1865) (superlistapp#1880) * checking for existing attributions across multiple nodes before toggling incoming attributions on nodes * checking for single attribution throughout node, docs updated * tests added * refactored logic for checking if all nodes have all attributions for any of their characters * refactored approach to validating whether a particular attribution should be toggled for a node * added findEditor helper to SuperEditorInspector * added toggleAttributionsForDocumentSelection to SuperEditorInspector * using newly added test tools * added some helpers to reduce boilerplate * refactor * added more tests for various combinations for attributions toggling on nodes * accounting for scenario when multiple attributions are being applied to a selection, tests updated * redundant comments removed * updates * tests comments updated * reverted back to a more simple solution for the issue * formatting updates * added helper methods to reduce boilerplate * refactor * using add/remove attribution methods from AttributedText instead of spans * checking text markers instead of serializing to markdown for no attributions cheks * formatting updates * test comments updated * tests naming updates * tests added for partial selections across multiple nodes * moved few new document creators to test_documents, refactoring * moved toggleAttributionsForDocumentSelection to test file where it's used * renamed newly added test documents * refactored how we fetch editor in tests * test documents updated
…om generic event to a specific TextInsertionEvent for InsertAttributedTextCommand (Resolves superlistapp#1884) (superlistapp#1908)
…n EditorReaction (Resolves superlistapp#1866) (superlistapp#1896)
…hCustomParent (Resolves superlistapp#1963) (superlistapp#1971)
* Allow 'any' intl package (superlistapp#895) * [Flutter Team] - Remove deprecated `showTrackOnHover` (superlistapp#1851) * Fix nullability hints --------- Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Qun Cheng <[email protected]>
Resolves superlistapp#1959) (superlistapp#1995) [SuperEditor][Mobile] Fix downstream image caret position (Resolves superlistapp#1959) (superlistapp#1967) Co-authored-by: Angelo Silvestre <[email protected]>
…mid_april24_midmay24_updates
This reverts commit e9c01d5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.