Node: fixed crash when deleting PeerInfo that's still in use

BeamMW · Jan 3, 2019 · d9d1205 · d9d1205
1 parent 202b111
commit d9d1205
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/node/node.cpp b/node/node.cpp
@@ -1186,6 +1186,11 @@ void Node::Peer::OnMsg(proto::Authentication&& msg)
 
         if (!pPi->m_pLive->IsSecureOut() || (m_This.m_MyPublicID > msg.m_ID))
         {
+			// detach from that peer
+			assert(pPi == pPi->m_pLive->m_pInfo);
+			pPi->m_pLive->m_pInfo = nullptr;
+			pPi->m_pLive = nullptr;
+
             pPi->m_pLive->DeleteSelf(false, ByeReason::Duplicate);
             assert(!pPi->m_pLive);
         }