Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #158

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

JOSS paper #158

wants to merge 4 commits into from

Conversation

orbeckst
Copy link
Member

Short software paper for submission to the Journal of Open Source Software.

The paper will be part of the GromacsWrapper repository; this appears to be the common pattern with other JOSS papers.

Closes Issue #147 (This branch will be merged when the paper is submitted.)

Author contributions

  • read JOSS paper #147 for criteria for inclusion
  • reply to JOSS paper #147 and state that you want to be an author
  • for right now: fork the repo and submit PRs against the paper branch or try to edit the paper.md directly on GitHub.

@orbeckst
Copy link
Member Author

You can start by updating your author meta data in

Follow the examples in the file.

@codecov
Copy link

codecov bot commented Aug 18, 2018

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   62.63%   62.63%           
=======================================
  Files          21       21           
  Lines        4135     4135           
  Branches      662      662           
=======================================
  Hits         2590     2590           
  Misses       1359     1359           
  Partials      186      186

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa1905...03eac1a. Read the comment docs.

@pslacerda
Copy link
Collaborator

I'm a bit worried about the acceptance criteria of JOSS. Even if super convenient, this library is largely a python binding to Gromacs command line interface, and they are somewhat strict about bindings. What do you think?

And what about I'm expect to write? Automatic cached documentation generated from the original tools? Was nice to found the performance issue using the profiler, someone with internal knowledge could find intuitively, but for foreigners is easy to find the spot only profiling.

@pslacerda
Copy link
Collaborator

pslacerda commented Aug 19, 2018

I would say it pass the criteria because of lots of working knowledge packed in GromacsWrapper. Just by reading the examples was helpful to improve my Gromacs workflows. For example, I'm doing my first membrane simulation and didn't know that was handy to align the membrane on the XY plane with trj_xyfitted.

@PicoCentauri
Copy link
Collaborator

Probably its my fault but I was not able to push my meta data to the PR. Are there any things I have to consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants