MAINT: Move fixtures from test_plotting.py
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move fixtures from `test_plotting.py` to `conftest.py` to make them more broadly available to other tests. * Change scope of fixtures in `conftest.py` from "class" to "module" since they can all be used across an entire module * Fix comments in `test_kda.py` and `test_plotting.py` * Remove unnecessary code from testing fixture `results_4wl`
|
I looked over the diff and all changes look good. Tests are passing. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move fixtures from
test_plotting.pytoconftest.pyto make them more broadlyavailable to other tests.
Change scope of fixtures in
conftest.pyfrom "class" to "module"since they can all be used across an
entire module
Fix comments in
test_kda.pyandtest_plotting.pyRemove unnecessary code from testing fixture
results_4wl