MAINT: Refactor calc_net_cycle_flux
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactors `calc_net_cycle_flux` to use `calc_net_cycle_flux_from_diags` directly. Also simplifies `calc_net_cycle_flux_from_diags` to make clear what is changing for both cases of `output_strings`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed both
calc_net_cycle_fluxandcalc_net_cycle_flux_from_diagswere identical code with the exception of 1 line. This just simplifies the code a bit so we don't have redundant code in two functions.Changes
calc_net_cycle_fluxto usecalc_net_cycle_flux_from_diagsdirectly.Also simplifies
calc_net_cycle_flux_from_diagsto make clear what is changing for both cases of
output_strings.