lint: Configure ruff for this project and fix problems #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 87.64% 87.54% -0.10%
==========================================
Files 53 53
Lines 2331 2313 -18
Branches 298 296 -2
==========================================
- Hits 2043 2025 -18
Misses 226 226
Partials 62 62 ☔ View full report in Codecov by Sentry. |
BenjaminSchubert
force-pushed
the
bschubert/lint-ruff
branch
from
a8335bd
to
c8afe9e
Compare
BenjaminSchubert
changed the title
Most notable are: - require boolean arguments to be passed as keywords Otherwise it can't be quite confusing and ordering becomes less clear. Overall this reduces errors - Ensure all imports used for typechecking are guarded by TYPE_CHECKING
BenjaminSchubert
force-pushed
the
bschubert/lint-ruff
branch
from
c8afe9e
to
b7b9ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notable are:
Otherwise it can't be quite confusing and ordering becomes less clear.
Overall this reduces errors