Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint(ruff): Enable newer annotation style #59

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

BenjaminSchubert
Copy link
Owner

No description provided.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (638611f) 87.54% compared to head (82379eb) 87.61%.

Files Patch % Lines
src/dwas/_frontend.py 75.00% 1 Missing ⚠️
src/dwas/_steps/handlers.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   87.54%   87.61%   +0.06%     
==========================================
  Files          53       53              
  Lines        2313     2325      +12     
  Branches      296      296              
==========================================
+ Hits         2025     2037      +12     
  Misses        226      226              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We do not need the annotations at runtime, this also will enable us to
use newer style annotations
We do not need them at runtime, and the import from __future__ allows us
to not parse them. As such, we can use newer syntax
@BenjaminSchubert BenjaminSchubert merged commit 9494f0a into main Dec 31, 2023
20 checks passed
@BenjaminSchubert BenjaminSchubert deleted the bschubert/upgrade-code branch December 31, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant