Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Tle5012b encoder #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions edg/parts/Tle5012b.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
from edg.abstract_parts import *
from edg.parts.JlcPart import JlcPart


class Tle5012b_Device(InternalSubcircuit, FootprintBlock, JlcPart):
def __init__(self) -> None:
super().__init__()
self.vdd = self.Port(VoltageSink(
voltage_limits=(3.0, 5.5) * Volt,
current_draw=(5 * uAmp, 16 * mAmp)
))
self.gnd = self.Port(Ground())

dio_model = DigitalBidir.from_supply(
self.gnd, self.vdd,
voltage_limit_tolerance=(-0.3, 0.3) * Volt,
input_threshold_factor=(0.3, 0.7),
current_limits=(5 * uAmp, 25 * mAmp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where'd this come from?
It seems that it can sink up to -25mA and has a pull-up rating of 3uA? I don't see a source current limit even though there's a section on the SSC interface in push-pull configuration.

)
dio_model_sck = DigitalSink.from_supply(self.gnd, self.vdd,
voltage_limit_tolerance=(-0.3, 0.3) * Volt)
self.sck = self.Port(dio_model_sck)
self.csq = self.Port(dio_model_sck)
Comment on lines +20 to +23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dio_model_sck = DigitalSink.from_supply(self.gnd, self.vdd,
voltage_limit_tolerance=(-0.3, 0.3) * Volt)
self.sck = self.Port(dio_model_sck)
self.csq = self.Port(dio_model_sck)
self.sck = self.Port(DigitalSink.from_bidir(dio_model))
self.csq = self.Port(DigitalSink.from_bidir(dio_model))

I think most of the pindefs can be reused?

self.data = self.Port(DigitalSink.from_bidir(dio_model))

if_dio_model = DigitalBidir.from_supply(
self.gnd, self.vdd,
voltage_limit_tolerance=(-0.3, 0.3) * Volt,
input_threshold_factor=(0.3, 0.7),
current_limits=(5 * uAmp, 15 * mAmp)
)

self.ifa = self.Port(DigitalSource.from_bidir(if_dio_model), optional=True)
self.ifb = self.Port(DigitalSource.from_bidir(if_dio_model), optional=True)
self.ifc = self.Port(DigitalSource.from_bidir(if_dio_model), optional=True)

def contents(self) -> None:
self.footprint(
'U', 'fp:SO8_PG-DSO-8_INF',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'U', 'fp:SO8_PG-DSO-8_INF',
'U', 'Package_SO:SOP-8_3.9x4.9mm_P1.27mm',

Can a standard KiCad footprint be used? This one should be compatible, though the pads stretch more on the inside

{
'1': self.ifc,
'2': self.sck,
'3': self.csq,
'4': self.data,
'5': self.ifa,
'6': self.vdd,
'7': self.gnd,
'8': self.ifb
},
mfr='Infineon', part='Tle5012b',
datasheet='https://www.infineon.com/cms/en/product/sensor/magnetic-sensors/magnetic-position-sensors/angle-sensors/tle5012b-e1000/'
)
self.assign(self.lcsc_part, 'C123083')
self.assign(self.actual_basic_part, False)


class Tle5012b(Magnetometer, DefaultExportBlock):
"""Angle sensor based on Giant Magneto Resistance (GMR) for precise angular position sensing."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider quantifying the precision. I think it's a 15-bit angle output?


def __init__(self):
super().__init__()
self.ic = self.Block(Tle5012b_Device())
self.gnd = self.Export(self.ic.gnd, [Common])
self.pwr = self.Export(self.ic.vdd, [Power])

self.sck = self.Export(self.ic.sck, optional=True)
self.csq = self.Export(self.ic.csq, optional=True)
self.data = self.Export(self.ic.data, optional=True)

self.ifa = self.Export(self.ic.ifa, optional=True,
doc="IIF Phase A / Hall Switch Signal 1 / PWM / SPC output (input for SPC trigger only)")
self.ifb = self.Export(self.ic.ifb, optional=True, doc="IIF Phase B / Hall Switch Signal 2")
self.ifc = self.Export(self.ic.ifc, optional=True, doc="External Clock / IIF Index / Hall Switch Signal 3")
Comment on lines +70 to +73
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use these? If not, I'd consider leaving these out for simplicity, for now.

Part of the reason is that design-side, I'd like the application circuit to provide high-level interfaces, and the application circuit could figure out how to map like PWM to device pins and enforce constraints (such as only one of the IO options can be active)


def contents(self):
super().contents()
self.vdd_cap = self.Block(DecouplingCapacitor(100 * nFarad(tol=0.2))).connected(self.gnd, self.ic.vdd)
1 change: 1 addition & 0 deletions edg/parts/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from .Switches import SmtSwitch, SmtSwitchRa, KailhSocket
from .RotaryEncoder_Alps import Ec11eWithSwitch, Ec11j15WithSwitch, Ec05e
from .RotaryEncoder_Bourns import Pec11s
from .Tle5012b import Tle5012b
from .DirectionSwitch_Alps import Skrh
from .JlcCrystal import JlcCrystal
from .JlcOscillator import JlcOscillator
Expand Down
Loading