-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insertion live template for connections #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds insertion live template support for GUI connect operations. Experimental, partially implemented (for single ports only, limited support for arrays and boundary ports), currently behind a toggle in the settings menu.
Architecturally, this separates the connect-builder (which determines which connections are allowed to a link) from the block analysis (which determines which ports are in a connected group, and what connects are available to a port), from the IR mutator (the executor, which takes a connectivity change and updates the Block IR), from the code generator / insertion live template. Probably more code to before, but in chunks that actually make more sense. Prior, GUI connects were much more monolithic code-wise.
Other functional changes:
Other refactoring / infrastructural changes:
Future TODOs