Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: YASNCB (Yet Another Strict Null Checks Branch) #1703

Draft
wants to merge 73 commits into
base: dev
Choose a base branch
from
Draft

WIP: YASNCB (Yet Another Strict Null Checks Branch) #1703

wants to merge 73 commits into from
+700 −406

Commits on Apr 30, 2022

  1. Fix nulls/undefineds and improve repl info parser for params

    @corasaurus-hex
    corasaurus-hex committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    aa2250b View commit details
    Browse the repository at this point in the history

  2. Stop using deprecated function and use our own instead

    @corasaurus-hex
    corasaurus-hex committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    a697c11 View commit details
    Browse the repository at this point in the history

  3. Fix an undefined value in utilities

    @corasaurus-hex
    corasaurus-hex committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    02d317d View commit details
    Browse the repository at this point in the history

  4. Help typescript out with some type assertions in cursor-doc model

    @corasaurus-hex
    corasaurus-hex committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    02960ca View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Fix null checks for project-types

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    0f72124 View commit details
    Browse the repository at this point in the history

  2. Fix null checks for completion provider

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    9426650 View commit details
    Browse the repository at this point in the history

  3. Fix nulls in src/connector.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    c73129e View commit details
    Browse the repository at this point in the history

  4. Fix null in src/converters.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    3dd6b85 View commit details
    Browse the repository at this point in the history

  5. Fix nulls in cursor-doc indent and improve performance

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6e6640f View commit details
    Browse the repository at this point in the history

  6. Fix nulls in clojure-lexer

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    5aad863 View commit details
    Browse the repository at this point in the history

  7. Fix nulls in lexer

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    0510888 View commit details
    Browse the repository at this point in the history

  8. Fix nulls in paredit.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    347e7eb View commit details
    Browse the repository at this point in the history

  9. Fix nulls for _rangesForSexpsInList 

    This is an odd one. The types were very different for useRowCol = true
and useRowCol = false and so I needed to use generics to clean it up.
    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    2527798 View commit details
    Browse the repository at this point in the history

  10. Fix remaining nulls for token-cursor.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    be6765b View commit details
    Browse the repository at this point in the history

  11. Fix more nulls in paredit

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    46fa6ad View commit details
    Browse the repository at this point in the history

  12. Fix nulls in undo.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    ff9f09d View commit details
    Browse the repository at this point in the history

  13. Fix types for evaluating custom snippets

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6e17118 View commit details
    Browse the repository at this point in the history

  14. Fix types in repl-session

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    39c3208 View commit details
    Browse the repository at this point in the history

  15. Fix null checks for clojuredocs

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    e2622a2 View commit details
    Browse the repository at this point in the history

  16. Fix debugger-related null checks

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    7f77027 View commit details
    Browse the repository at this point in the history

  17. Fix more null checks in the debugger

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    28cf0f3 View commit details
    Browse the repository at this point in the history

  18. Another null check issue fixed, this time in doc-mirror

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    25af9b9 View commit details
    Browse the repository at this point in the history

  19. Fix null check issues in src/evaluate.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    4043c42 View commit details
    Browse the repository at this point in the history

  20. Fix some null check issues in extension tests

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    74ab8f9 View commit details
    Browse the repository at this point in the history

  21. Fix null check issues in src/extension.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6a04743 View commit details
    Browse the repository at this point in the history

  22. Fix a ton of null check issues in extension.ts for highlighting

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    b91edb1 View commit details
    Browse the repository at this point in the history

  23. Fix live-share.ts null check issues

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    a58fbf1 View commit details
    Browse the repository at this point in the history

  24. Fix a number of strict null check issues in lsp code

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    30cc621 View commit details
    Browse the repository at this point in the history

  25. Fix null check issues in providers

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6e26d72 View commit details
    Browse the repository at this point in the history

  26. Fix strict null check issue in repl-history.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    387326f View commit details
    Browse the repository at this point in the history

  27. Fix strict null check issue in when-contexts.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    c8c7ee7 View commit details
    Browse the repository at this point in the history

  28. Fix strict null check issues for src/connector.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    cb079b5 View commit details
    Browse the repository at this point in the history

  29. Fix strict null check issues for src/evaluate.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    20d0f2c View commit details
    Browse the repository at this point in the history

  30. Fix strict null check issues for src/nrepl/bencode.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    1cddd85 View commit details
    Browse the repository at this point in the history

  31. Fix strict null check issues for src/nrepl/connectSequence.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    49a0f0f View commit details
    Browse the repository at this point in the history

  32. Fix strict null check issues for src/nrepl/index.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    b9cdce3 View commit details
    Browse the repository at this point in the history

  33. Fix strict null check issues for src/nrepl/jack-in-terminal.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    d608036 View commit details
    Browse the repository at this point in the history

  34. Fix strict null check issues for src/nrepl/jack-in.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    b33def4 View commit details
    Browse the repository at this point in the history

  35. Fix strict null check issues for src/nrepl/project-types.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    2dc2abf View commit details
    Browse the repository at this point in the history

  36. Fix strict null check issues for src/nrepl/repl-start.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    407b589 View commit details
    Browse the repository at this point in the history

  37. Fix strict null check issues for src/paredit/extension.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    5e2ed4b View commit details
    Browse the repository at this point in the history

  38. Fix strict null check issues for src/project-root.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6ff6e9b View commit details
    Browse the repository at this point in the history

  39. Fix strict null check issues for src/providers/definition.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    e8c4cb1 View commit details
    Browse the repository at this point in the history

  40. Fix strict null check issues for src/providers/signature.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    b6b8db4 View commit details
    Browse the repository at this point in the history

  41. Fix strict null check issues for src/refresh.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    aea1267 View commit details
    Browse the repository at this point in the history

  42. Fix strict null check issues for src/results-output/results-doc.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    c6fd333 View commit details
    Browse the repository at this point in the history

  43. Fix strict null check issues for src/statusbar.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    8425e1a View commit details
    Browse the repository at this point in the history

  44. Fix strict null check issues for src/testRunner.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    c3735e3 View commit details
    Browse the repository at this point in the history

  45. Fix strict null check issues for src/util/cursor-get-text.ts

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    1cdcd92 View commit details
    Browse the repository at this point in the history

  46. Enable strict null checks for typescript

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    fcf14e0 View commit details
    Browse the repository at this point in the history

  47. Run prettier formatter

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    adfe62a View commit details
    Browse the repository at this point in the history

  48. Rename getSession => tryToGetSession and make another getSession 

    getSession will throw an error if no session was found.
    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    b119164 View commit details
    Browse the repository at this point in the history

  49. Restore whitespace

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    5da7c79 View commit details
    Browse the repository at this point in the history

  50. Remove assertions that are no longer needed due to new function

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    ac8f195 View commit details
    Browse the repository at this point in the history

  51. No need to set to a variable before use

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    c1417db View commit details
    Browse the repository at this point in the history

  52. More formatting

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    f310e64 View commit details
    Browse the repository at this point in the history

  53. Minimize more changes to connector

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    859a6bb View commit details
    Browse the repository at this point in the history

  54. Whoops, use a record type not a map type

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    7ac6f57 View commit details
    Browse the repository at this point in the history

  55. Ensure same behavior here

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    1e921d6 View commit details
    Browse the repository at this point in the history

  56. Split project root local fns into tryToGet + get

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    61437fe View commit details
    Browse the repository at this point in the history

  57. Move undefined check closer to where it is needed

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    d0cd19c View commit details
    Browse the repository at this point in the history

  58. Forgot a bang !

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    0778866 View commit details
    Browse the repository at this point in the history

  59. Swap out use of regex for much faster substring search

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    857054d View commit details
    Browse the repository at this point in the history

  60. Use function instead of try + assert

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    5106ee8 View commit details
    Browse the repository at this point in the history

  61. Compare against the right types

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    18d7761 View commit details
    Browse the repository at this point in the history

  62. Get rid of unused import

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    3d1aec3 View commit details
    Browse the repository at this point in the history

  63. Move type checking functions out to an ns without vscode

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    b83c26d View commit details
    Browse the repository at this point in the history

  64. Fix some null checks

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    13d7e82 View commit details
    Browse the repository at this point in the history

  65. Fix the token cursor genericized function

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    bc7fadd View commit details
    Browse the repository at this point in the history

  66. Reformat the tsconfig

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    cd0d893 View commit details
    Browse the repository at this point in the history

  67. Use prettier to format JSON files in the project

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6414e32 View commit details
    Browse the repository at this point in the history

  68. Debug lsp downloads

    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    f5c1fbd View commit details
    Browse the repository at this point in the history

  69. Add some debugging so we can figure out why integration tests are 

    failing
    @corasaurus-hex
    corasaurus-hex committed May 1, 2022
    Configuration menu
    Copy the full SHA
    df16f82 View commit details
    Browse the repository at this point in the history