Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmin parameter to the Histogram2D class. #36

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

bruno-pannunzio
Copy link
Contributor

This PR proposes the addition of the cmin parameter to the class Histogram2D to be able to modify the cmin parameter of the matplotlib.pyplot.hist2d function called by the data method.

This addition allows to avoid the display of bin with less counts than the cmin value. This will allow to modify the parameter externally, being able to make the background transparent and selecting afterwards the background color by setting the facecolor of the matplotlib axis.

@bruno-pannunzio
Copy link
Contributor Author

Hi @zoccoler! I opened this PR as discussed. It's a small modification but others can benefit also from this. Please let me know if you want me to modify something and I'll update the PR.

@zoccoler
Copy link
Contributor

Hi @bruno-pannunzio ,

Thanks for contributing here! I just changed the version and will merge now.
Please test it if it is useful for the napari-phasors and let me know, so that I make a new release here.
For the moment, please clone the repo, install the dev version and use the main branch to do the tests.

@zoccoler zoccoler merged commit 8639d09 into BiAPoL:main Oct 16, 2024
8 of 9 checks passed
@bruno-pannunzio
Copy link
Contributor Author

Thanks @zoccoler! This works perfect with our napari-phasors plugin, after installing the dev version:

image

@zoccoler
Copy link
Contributor

Awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants