-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DNA_Gap cannot be meaningfully translated, as it does not correspond to any nucleotides, not even an unknown one. In fact, it's dubious that it's even a nucleotide at all. This PR makes `translate(!)` error when run on sequences with gaps, whereas before this PR this was undefined behaviour (out-of-bounds access). Alternative solutions could be to silently skip gaps, which is biologically meaningful, but might lead to strange errors, or to insert AA_Gap, which can only be done if the gaps come in groups of three corresponding to a whole gap codon. In the future we could change behaviour to skip gaps. See issue 277
- Loading branch information
1 parent
c43fd6e
commit 1ccb602
Showing
3 changed files
with
13 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
name = "BioSequences" | ||
uuid = "7e6ae17a-c86d-528c-b3b9-7f778a29fe59" | ||
authors = ["Sabrina Jaye Ward <[email protected]>", "Jakob Nissen <[email protected]>"] | ||
version = "3.1.4" | ||
version = "3.1.5" | ||
|
||
[deps] | ||
BioSymbols = "3c28c6f8-a34d-59c4-9654-267d177fcfa9" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ccb602
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaRegistrator register
1ccb602
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registration pull request created: JuliaRegistries/General/86058
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via: