hotfix for reverse_complementing a slice of a longseq (#111)

* hotfix for reverse_complementing a slice of a longseq * Implement shallow copy fix proposed by BenJWard
BioJulia · Jun 24, 2020 · 312e274 · 312e274
1 parent 01fbc26
commit 312e274
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/longsequences/transformations.jl b/src/longsequences/transformations.jl
@@ -166,10 +166,7 @@ function reverse_complement!(seq::LongSequence{<:NucleicAcidAlphabet})
 end
 
 function reverse_complement(seq::LongSequence{<:NucleicAcidAlphabet})
-    cp = typeof(seq)(unsigned(length(seq)))
-    pred = x -> complement_bitpar(x, Alphabet(seq))
-    reverse_data_copy!(pred, cp.data, seq.data, BitsPerSymbol(seq))
-    return zero_offset!(cp)
+    return reverse_complement!(copy(seq))
 end
 
 ###

diff --git a/test/longsequences/transformations.jl b/test/longsequences/transformations.jl
@@ -85,6 +85,8 @@
         @test String(seq) == seq_string
         @test String(seq2) == reverse(dna_complement(seq_string[100:200]))
 
+	slice = randdnaseq(10)[2:9]
+	@test reverse_complement(reverse_complement(slice)) == slice
     end
 
     @testset "Map" begin