-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guessparse function #269
base: master
Are you sure you want to change the base?
Conversation
This function is a quick-and-dirty parser function from `AbstractString` to `LongSequence`, with autodetection of the alphabet. It's meant to be used in ephemeral REPL work, and very clearly documented to be unstable and subject to change. See BioJulia#268
Codecov ReportBase: 91.20% // Head: 90.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 91.20% 90.58% -0.63%
==========================================
Files 31 31
Lines 2400 2421 +21
==========================================
+ Hits 2189 2193 +4
- Misses 211 228 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
possible_encodings(b::UInt8)::UInt8 | ||
|
||
Returns a `UInt8` with any of the 4 lower bits set: | ||
* Bit 0: Valid `RNA` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid DNA
?
This looks great, thanks @jakobnissen! I like having both the This seems much more efficient than I was initially picturing (using regex or the tryparse approach), which is excellent. |
I wonder if it would be worth looking at I'm wondering if we want to always return a type, or throw an error if it's ambiguous... Maybe as an alternative the the later, offer an optional type to use as a default, like For bikeshedding, I quite liked swagparse, but that's not very discoverable... then again, might be worth being silly if we want to signal that this is experimental/unstable |
This function is a quick-and-dirty parser function from
AbstractString
toLongSequence
, with autodetection of the alphabet. It's meant to be used in ephemeral REPL work, and very clearly documented to be unstable and subject to change.See #268
This is just a draft. The implementation is straightforward, but we might want to think about whether we want this, and what it should be called.
Preferably, the name should be:
TODO: