Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forwarded losses and fix NPV per #180 #182

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Add forwarded losses and fix NPV per #180 #182

merged 2 commits into from
Jan 10, 2024

Conversation

yalinli2
Copy link
Member

@yalinli2 yalinli2 commented Jan 9, 2024

See details in #180

@yoelcortes
Copy link
Member

@yalinli2,

Cool! Thanks for making these changes. I made the following updates:

  1. I separated the taxable_earnings calculation from forwarded loses to optimize methods like solve_price and solve_IRR which run NPV calculations multiple times.
  2. I changed the name pay_interest_during_construction with accumulate_interest_during_construction for more clarity. If accumulate_interest_during_construction is True, the interest is payed later as part of the loan principal. If False, the interest during construction is payed immediately (in this case by equity).

Using your last test in #180, I get the same results.

Thanks so much!

@yoelcortes yoelcortes merged commit 3bc37b1 into master Jan 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants