Skip to content

Qodana

Qodana #269

Manually triggered March 20, 2024 22:48
Status Success
Total duration 6m 39s
Artifacts

code_quality.yml

on: workflow_dispatch
Fit to window
Zoom out
Zoom in

Annotations

174 warnings and 69 notices
Class is exposed outside of its visibility scope: wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java#L202
Class `PluginPipeline` is exposed outside its defined visibility scope
Class is exposed outside of its visibility scope: wrapper/src/main/java/software/amazon/jdbc/hostlistprovider/RdsHostListProvider.java#L224
Class `FetchTopologyResult` is exposed outside its defined visibility scope
Class is exposed outside of its visibility scope: wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java#L107
Class `PluginChainJdbcCallable` is exposed outside its defined visibility scope
Class is exposed outside of its visibility scope: wrapper/src/main/java/software/amazon/jdbc/util/CacheMap.java#L27
Class `CacheItem` is exposed outside its defined visibility scope
Class is exposed outside of its visibility scope: wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java#L274
Class `PluginPipeline` is exposed outside its defined visibility scope
Class is exposed outside of its visibility scope: wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java#L243
Class `PluginChainJdbcCallable` is exposed outside its defined visibility scope
Constant values: wrapper/src/main/java/software/amazon/jdbc/plugin/efm/HostMonitoringConnectionPlugin.java#L117
Condition `monitorServiceSupplier == null` is always `false`
Constant values: wrapper/src/main/java/software/amazon/jdbc/util/telemetry/XRayTelemetryContext.java#L120
Condition `telemetryContext.traceEntity.getParent() != null` is always `true`
Constant values: wrapper/src/main/java/software/amazon/jdbc/plugin/efm2/HostMonitoringConnectionPlugin.java#L115
Condition `monitorServiceSupplier == null` is always `false`
Deprecated API usage: wrapper/src/main/java/software/amazon/jdbc/wrapper/ConnectionWrapper.java#L943
Overrides deprecated method in 'java.lang.Object'
Deprecated API usage: wrapper/src/main/java/software/amazon/jdbc/util/WrapperUtils.java#L466
'newInstance()' is deprecated since version 9
Deprecated API usage: wrapper/src/main/java/software/amazon/jdbc/util/WrapperUtils.java#L534
'isAccessible()' is deprecated since version 9
Infinite loop statement: wrapper/src/main/java/software/amazon/jdbc/util/SlidingExpirationCacheWithCleanupThread.java#L57
`while` statement cannot complete without throwing an exception
'size() == 0' can be replaced with 'isEmpty()': wrapper/src/main/java/software/amazon/jdbc/LeastConnectionsHostSelector.java#L52
`eligibleHosts.size() == 0` can be replaced with 'eligibleHosts.isEmpty()'
'size() == 0' can be replaced with 'isEmpty()': wrapper/src/main/java/software/amazon/jdbc/RandomHostSelector.java#L42
`eligibleHosts.size() == 0` can be replaced with 'eligibleHosts.isEmpty()'
Call to 'printStackTrace()': examples/HibernateExample/src/main/java/software/amazon/JpaExample.java#L59
Call to `printStackTrace()` should probably be replaced with more robust logging
Unchecked warning: wrapper/src/main/java/software/amazon/jdbc/util/SlidingExpirationCache.java#L264
Unchecked cast: 'java.lang.Object' to 'software.amazon.jdbc.util.SlidingExpirationCache.CacheItem'
Unused import: examples/AWSDriverExample/src/main/java/software/amazon/ReadWriteSplittingPostgresExample.java#L27
Unused import `import software.amazon.jdbc.HikariPooledConnectionProvider;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/plugin/iam/LightRdsUtility.java#L34
Unused import `import software.amazon.jdbc.util.Messages;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/hostavailability/HostAvailabilityStrategy.java#L19
Unused import `import software.amazon.jdbc.AwsWrapperProperty;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/util/WrapperUtils.java#L53
Unused import `import java.util.concurrent.locks.ReentrantLock;`
Unused import: examples/SpringHibernateBalancedReaderTwoDataSourceExample/src/main/java/example/spring/Config.java#L45
Unused import `import software.amazon.jdbc.profile.ConfigurationProfileBuilder;`
Unused import: examples/HikariExample/src/main/java/software/amazon/HikariExample.java#L25
Unused import `import java.util.Properties;`
Unused import: examples/SpringHibernateBalancedReaderTwoDataSourceExample/src/main/java/example/spring/Config.java#L43
Unused import `import software.amazon.jdbc.HikariPooledConnectionProvider;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L28
Unused import `import java.util.Collections;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L25
Unused import `import java.sql.DriverManager;`
Unused import: examples/SpringHibernateBalancedReaderTwoDataSourceExample/src/main/java/example/spring/Config.java#L46
Unused import `import software.amazon.jdbc.profile.ConfigurationProfilePresetCodes;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/util/PropertyUtils.java#L31
Unused import `import software.amazon.awssdk.services.rds.endpoints.internal.Value.Bool;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/HostSpecBuilder.java#L20
Unused import `import java.time.Instant;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/authentication/AwsCredentialsManager.java#L26
Unused import `import software.amazon.jdbc.util.Messages;`
Unused import: examples/AWSDriverExample/src/main/java/software/amazon/ReadWriteSplittingPostgresExample.java#L26
Unused import `import software.amazon.jdbc.ConnectionProviderManager;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/plugin/staledns/AuroraStaleDnsPlugin.java#L34
Unused import `import software.amazon.jdbc.util.Messages;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/util/RdsUtils.java#L19
Unused import `import java.util.HashMap;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L33
Unused import `import java.util.stream.Collectors;`
Unused import: wrapper/src/main/java/software/amazon/jdbc/plugin/efm/HostMonitoringConnectionPlugin.java#L43
Unused import `import software.amazon.jdbc.util.telemetry.TelemetryFactory;`
Unnecessary modifier: examples/SpringTxFailoverExample/src/main/java/example/ExampleDao.java#L25
Modifier `public` is redundant for interface members
Unnecessary modifier: examples/SpringTxFailoverExample/src/main/java/example/ExampleDao.java#L23
Modifier `public` is redundant for interface members
Unnecessary modifier: examples/SpringTxFailoverExample/src/main/java/example/ExampleDao.java#L27
Modifier `public` is redundant for interface members
Unnecessary 'return' statement: examples/AWSDriverExample/src/main/java/software/amazon/PgFailoverSample.java#L105
`return` is unnecessary as the last statement in a 'void' method
Unused assignment: wrapper/src/main/java/software/amazon/jdbc/util/RdsUtils.java#L256
Variable `matcher` initializer `null` is redundant
qodana
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: JetBrains/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Method can be extracted: examples/AWSDriverExample/src/main/java/software/amazon/TelemetryMetricsOTLPExample.java#L71
It's possible to extract method returning 'properties' from a long surrounding method
Method can be extracted: examples/AWSDriverExample/src/main/java/software/amazon/TelemetryTracingXRayExample.java#L46
It's possible to extract method returning 'properties' from a long surrounding method
Method can be extracted: examples/AWSDriverExample/src/main/java/software/amazon/DatasourceExample.java#L43
It's possible to extract method returning 'targetDataSourceProps' from a long surrounding method
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java#L101
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/DefaultConnectionPlugin.java#L64
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/AwsWrapperProperty.java#L26
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L85
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfileBuilder.java#L39
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L41
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L34
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L35
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L46
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/DefaultConnectionPlugin.java#L65
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L44
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/FastestResponseStrategyPlugin.java#L71
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/efm2/HostMonitoringConnectionPlugin.java#L80
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/efm/HostMonitoringConnectionPlugin.java#L82
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L45
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L92
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/NodeResponseTimeMonitor.java#L56
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L37
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L40
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/HostResponseTimeServiceImpl.java#L61
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfileBuilder.java#L37
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L36
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L86
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L43
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/wrapper/ConnectionWrapper.java#L72
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L83
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/NodeResponseTimeMonitor.java#L57
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java#L100
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/HikariPooledConnectionProvider.java#L350
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L87
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfileBuilder.java#L41
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/efm/HostMonitoringConnectionPlugin.java#L83
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfileBuilder.java#L38
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/PluginServiceImpl.java#L74
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/HostResponseTimeServiceImpl.java#L59
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/wrapper/ConnectionWrapper.java#L74
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/FastestResponseStrategyPlugin.java#L70
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/NodeResponseTimeMonitor.java#L50
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L88
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/strategy/fastestresponse/FastestResponseStrategyPlugin.java#L69
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/efm2/HostMonitoringConnectionPlugin.java#L81
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfileBuilder.java#L35
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/DriverConnectionProvider.java#L53
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L91
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/efm2/HostMonitoringConnectionPlugin.java#L82
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L90
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L39
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfileBuilder.java#L40
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L89
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L47
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/PluginServiceImpl.java#L78
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/plugin/efm/HostMonitoringConnectionPlugin.java#L84
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfile.java#L38
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/DataSourceConnectionProvider.java#L55
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/DataSourceConnectionProvider.java#L54
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/profile/ConfigurationProfileBuilder.java#L36
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/HikariPooledConnectionProvider.java#L351
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@org.checkerframework.checker.nullness.qual.NonNull'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/ds/AwsWrapperDataSource.java#L84
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'
@NotNull/@Nullable problems: wrapper/src/main/java/software/amazon/jdbc/Driver.java#L56
The generated code will use '@org.jetbrains.annotations.Nullable' instead of '@org.checkerframework.checker.nullness.qual.Nullable'