[do not merge] suggested fix for auto-detect internal connection pooling #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystall-bitquill
force-pushed
the
issue-547
branch
from
2c39e7a
to
6670763
Compare
crystall-bitquill
changed the title
crystall-bitquill
force-pushed
the
issue-547
branch
2 times, most recently
from
9c94ab5
to
6873031
Compare
sergiyvamz
reviewed
Jul 21, 2023
| @@ -248,6 +255,10 @@ private boolean isReader(final @NonNull HostSpec hostSpec) { | |||
|
|
|||
| private void getNewWriterConnection(final HostSpec writerHostSpec) throws SQLException { | |||
| final Connection conn = this.pluginService.connect(writerHostSpec, this.properties); | |||
| final String driverProtocol = conn.getMetaData().getURL().split("//", 2)[0]; | |||
There was a problem hiding this comment.
PluginService may be extended to provide protocol.
crystall-bitquill
force-pushed
the
issue-547
branch
from
6873031
to
5943e15
Compare
sergiyvamz
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
This will be the suggested to be added to a customer PR (548), to close reader connections after switching to read-write only when internal connection pooling is used.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.