feat(root): add node 18 to engines and CI

TICKET: WP-338
BitGo · Jul 24, 2023 · 32bee57 · 32bee57
1 parent 2a3931e
commit 32bee57
Show file tree

Hide file tree

Showing 55 changed files with 58 additions and 59 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [16.x, 18.x]
 
     steps:
       - uses: actions/checkout@v3

diff --git a/.github/workflows/test_package_updates.yml b/.github/workflows/test_package_updates.yml
@@ -25,7 +25,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [16.x, 18.x]
 
     steps:
       - uses: actions/checkout@v3

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-14.18.0
+16.12.0
diff --git a/DEVELOPERS.md b/DEVELOPERS.md
@@ -1,7 +1,7 @@
 # Requirements
 
 - yarn version 1 (classic)
-- node version >=14.18.0 and <17
+- node version >=16 and <19
 
 # Installing
 
@@ -180,7 +180,7 @@ Engines should be set to the following:
 ```json
 {
   "engines": {
-    "node": ">=14.18.0 <17",
+    "node": ">=16 <19",
     "npm": ">=3.10.10"
   }
 }

diff --git a/README.md b/README.md
@@ -52,17 +52,16 @@ BitGoJS currently provides support for the following Node versions per package.j
 
 ```
 "engines": {
-  "node": ">=14.18.0 <17",
+  "node": ">=16 <19",
   "npm": ">=3.10.10"
 }
 ```
 
 We specifically limit our support to these versions of Node, not because this package won't work on other versions, but because these versions tend to be the most widely used in practice. It's possible the packages in this repository will work correctly on newer or older versions of Node, but we typically don't run automated tests against non-specified versions of Node (including odd versions), with the possible exception of the latest odd numbered version for advanced awareness of upcoming breaks in version support.
 
 As each Node LTS version reaches its end-of-life we will exclude that version from the node engines property of our package's package.json file. Removing a Node version is considered a breaking change and will entail the publishing of a new major version of this package. We will not accept any requests to support an end-of-life version of Node, and any pull requests or issues regarding support for an end-of-life version of Node will be closed. We will accept code that allows this package to run on newer, non-LTS, versions of Node. Furthermore, we will attempt to ensure our own changes work on the latest version of Node. To help in that commitment, our continuous integration setup runs the full test suite on the latest release of the following versions of node:
-
-- `>=14.18.0`
-- `16`
+- `>=16`
+- `19`
 
 JavaScript package managers should allow you to install this package with any version of Node, with, at most, a warning if your version of Node does not fall within the range specified by our node engines property. If you encounter issues installing this package on a supported version of Node, please report the issue to us.
 

diff --git a/modules/abstract-cosmos/package.json b/modules/abstract-cosmos/package.json
@@ -15,7 +15,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/abstract-eth/package.json b/modules/abstract-eth/package.json
@@ -15,7 +15,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/abstract-utxo/package.json b/modules/abstract-utxo/package.json
@@ -15,7 +15,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/account-lib/package.json b/modules/account-lib/package.json
@@ -24,7 +24,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "ISC",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "dependencies": {
     "@bitgo/sdk-coin-algo": "^1.3.27",

diff --git a/modules/bitgo/package.json b/modules/bitgo/package.json
@@ -16,7 +16,7 @@
   },
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=14 <17",
+    "node": ">=16 <19",
     "npm": ">=3.10.10"
   },
   "scripts": {

diff --git a/modules/sdk-coin-ada/package.json b/modules/sdk-coin-ada/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-algo/package.json b/modules/sdk-coin-algo/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-atom/package.json b/modules/sdk-coin-atom/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-avaxc/package.json b/modules/sdk-coin-avaxc/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-avaxp/package.json b/modules/sdk-coin-avaxp/package.json
@@ -26,7 +26,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "lint-staged": {
     "*.{js,ts}": [

diff --git a/modules/sdk-coin-bch/package.json b/modules/sdk-coin-bch/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-bcha/package.json b/modules/sdk-coin-bcha/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-bld/package.json b/modules/sdk-coin-bld/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-bsc/package.json b/modules/sdk-coin-bsc/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-bsv/package.json b/modules/sdk-coin-bsv/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-btc/package.json b/modules/sdk-coin-btc/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-btg/package.json b/modules/sdk-coin-btg/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-celo/package.json b/modules/sdk-coin-celo/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-cspr/package.json b/modules/sdk-coin-cspr/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-dash/package.json b/modules/sdk-coin-dash/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-doge/package.json b/modules/sdk-coin-doge/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-dot/package.json b/modules/sdk-coin-dot/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-eos/package.json b/modules/sdk-coin-eos/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-etc/package.json b/modules/sdk-coin-etc/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-eth/package.json b/modules/sdk-coin-eth/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-eth2/package.json b/modules/sdk-coin-eth2/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-ethw/package.json b/modules/sdk-coin-ethw/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-hash/package.json b/modules/sdk-coin-hash/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-hbar/package.json b/modules/sdk-coin-hbar/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-injective/package.json b/modules/sdk-coin-injective/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-ltc/package.json b/modules/sdk-coin-ltc/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-near/package.json b/modules/sdk-coin-near/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-osmo/package.json b/modules/sdk-coin-osmo/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-polygon/package.json b/modules/sdk-coin-polygon/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-rbtc/package.json b/modules/sdk-coin-rbtc/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-sei/package.json b/modules/sdk-coin-sei/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",

diff --git a/modules/sdk-coin-sol/package.json b/modules/sdk-coin-sol/package.json
@@ -18,7 +18,7 @@
   "author": "BitGo SDK Team <[email protected]>",
   "license": "MIT",
   "engines": {
-    "node": ">=14 <17"
+    "node": ">=16 <19"
   },
   "repository": {
     "type": "git",