-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(root): add support for node 18 #3758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahin-mohammad
force-pushed
the
WP-338/support-node-18
branch
from
July 25, 2023 19:46
0599313
to
2b8d6e8
Compare
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @types/[email protected], [email protected] |
zahin-mohammad
changed the title
feat(root): add node 18 to engines and CI
feat(root): add support for node 18
Jul 25, 2023
zahin-mohammad
force-pushed
the
WP-338/support-node-18
branch
7 times, most recently
from
July 26, 2023 12:55
c95a5f4
to
9bcde04
Compare
zahin-mohammad
force-pushed
the
WP-338/support-node-18
branch
from
July 26, 2023 14:13
d23ce35
to
93d2d58
Compare
zahin-mohammad
force-pushed
the
WP-338/support-node-18
branch
from
July 26, 2023 14:39
93d2d58
to
b858682
Compare
margueriteblair
approved these changes
Jul 26, 2023
davidkaplanbitgo
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of your proposed changes and which issue is being addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR adds support for node 18 and updates CI to add node 18 to the test matrix.
Issue Number
TICKET: WP-338
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Existing tests exist.
Checklist: