Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-etc): unsigned sweep support and fullsign support for etc via ovc #4853

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

bhupendra11
Copy link
Contributor

@bhupendra11 bhupendra11 commented Aug 27, 2024

TICKET: COIN-1595

Testing :

  • Used this change as a beta dependency in WRW and verified the creation of unsigned sweep for Mainnet
  • Used this change using yarn link in OVC to create half and then full signed transaction
  • Published the full signed transaction on mainnet

Unsigned sweep recovery

Half signed tx hash using user-priv key

{
    "halfSigned": {
        "txHex": "0xf9018c028504a817c8008307a12094af3fb10ea8f244924418fa0aa083308a474f411b80b90164391252150000000000000000000000004e0bfe6896c219328f90ba4254e373d28a7ed7bc0000000000000000000000000000000000000000000000000091a94863ca800000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000066d7f8b6000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000e000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000041ddcfeb075644af1816cc92091d0dfe18d0bb8e177719ab33d3b4d072bf2e4de132f2c699ea3141bb741b64c12195a93e189930433e8c579f70c95b6920d6379b1c00000000000000000000000000000000000000000000000000000000000000819d8080",
        "recipients": [
            {
                "address": "0x4e0bfe6896c219328f90ba4254e373d28a7ed7bc",
                "amount": "41000000000000000"
            }
        ],
        "expiration": 1725429942,
        "contractSequenceId": 10
    },
    "coin": "etc",
    "gasPrice": "20000000000",
    "gasLimit": "500000",
    "feesUsed": {
        "gasPrice": "20000000000",
        "gasLimit": "500000"
    },
    "amount": "41000000000000000",
    "isHalfSigned": true,
    "backupKeyNonce": 2,
    "walletContractAddress": "0xaf3fb10ea8f244924418fa0aa083308a474f411b"
}

Full sign tx hash backup-priv key

{
    "txHex": "0xf901cc028504a817c8008307a12094af3fb10ea8f244924418fa0aa083308a474f411b80b90164391252150000000000000000000000004e0bfe6896c219328f90ba4254e373d28a7ed7bc0000000000000000000000000000000000000000000000000091a94863ca800000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000066d7f8b6000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000e000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000041ddcfeb075644af1816cc92091d0dfe18d0bb8e177719ab33d3b4d072bf2e4de132f2c699ea3141bb741b64c12195a93e189930433e8c579f70c95b6920d6379b1c00000000000000000000000000000000000000000000000000000000000000819ea05af184842c34137bbb78450e37a7d0c59aa6310454c6380f3057528d91e1bd68a00a211e72e7708864abb0070c3ef97f99eb0a93558dbb9f4b38919e0fe9eb727c",
    "coin": "etc",
    "gasPrice": "20000000000",
    "gasLimit": "500000",
    "feesUsed": {
        "gasPrice": "20000000000",
        "gasLimit": "500000"
    },
    "amount": "41000000000000000"
}

resulted txHash received as response

{
    "apiVersion": "2023-04-25",
    "requestId": "66cec31bf1f8573719b634e0",
    "context": "broadcastETC",
    "data": {
        "item": {
            "transactionId": "0x1a5ea9cf5af25634191eb21b2d9187eefc7e8782e86b21c8ebc2b6dd8ee24f85"
        }
    }
}
Screenshot 2024-08-28 at 14 22 00 efc7e8782e86b21c8ebc2b6dd8ee24f85

Broadcasted Transaction on blockchain :

link

@bhupendra11 bhupendra11 force-pushed the COIN-1595-OVC-full-sign-support-for-etc branch 3 times, most recently from 057568b to 9f90097 Compare August 27, 2024 15:53
@bhupendra11 bhupendra11 changed the title feat(sdk-coin-etc): COIN-1595 OVC fullsign support for etc feat(sdk-coin-etc): unsigned sweep support and fullsign support for etc via ovc Aug 27, 2024
@bhupendra11 bhupendra11 marked this pull request as ready for review August 27, 2024 16:41
@bhupendra11 bhupendra11 requested a review from a team as a code owner August 27, 2024 16:41
@bhupendra11 bhupendra11 force-pushed the COIN-1595-OVC-full-sign-support-for-etc branch from 9f90097 to 206cd9b Compare August 27, 2024 16:43
@mukeshsp
Copy link
Contributor

please verify the withdraw after bumping on prod

@bhupendra11 bhupendra11 merged commit 638162b into master Aug 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants