mod unknown method #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
pushed a commit
to junderw/electrs
that referenced
this pull request
Dec 12, 2023
…nal-apis Protect internal apis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people access the electrs server using the unknown method, which is obsolete in electrum. It's unclear if this is due to a very old wallet or a homebrew application.
Currently, the unknown method is treated as an error and the peer is disconnected. But these peers reconnect every 10 seconds or every minute.
There seems to be something wrong with the error handling. However, I think there is also an idea that access by unknown method is not processed as an error.
This proposal simply returns a message for access using the unknown method. This drastically reduced the occurrence of "ERROR".