-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer: Fix problem with missing Office libs in latest version #34
base: master
Are you sure you want to change the base?
Conversation
I think I need to try again on a clean Windows without any Office installed. So far, I had this problem after installing WordsLive 0.9.22 at least once, but now I don't. Maybe it has to do with Office itself and its activation status (which my Office lost recently due to some imaginary hardware change... - but I won't deactivate it now for testing). |
Ok, here the update: When I install WordsLive 0.9.22 on a system where there is no Office, then I get the following when I add a song to the portfolio:
With the older 0.9.21 the same procedure works fine. |
Hm, do you have any idea which change in 0.9.22 might have caused this? I'm puzzled ... |
Between 0.9.21 and 0.9.22 the NuGet packages (which include Office Interop assemblies) were migrated from the old |
I think I found the reason for this issue. It has to do with the switch to https://learn.microsoft.com/en-us/visualstudio/vsto/how-to-install-office-primary-interop-assemblies?view=vs-2022 says that primary interop assemblies (PIAs) are embedded by default. So that is why we did not have those files in the old version and everything worked. But with Futher information:
Redistribution of the files: Microsoft provides these DLLs so that parts of them (basically just types/bindings) can be embedded into the end-user application. So I would assume copyright/licensing is not a real issue in practice. But unfortunately I also do not see a clear "allowed to distribute". |
When I build the installer locally, the produced artifact does not work: it complains about missing
Microsoft.Office.Interop.PowerPoint
. I checked with the latest release, actually I have the same problem there (when I uninstall WordsLive and reinstall it). Previously I did not have the issue, maybe because I only upgraded WordsLive. However, I'm a bit confused because earlier versions of WordsLive do not install that DLL as far as I can see, so not sure why I did not have problems earlier.With the changes in this PR it works for me, but please have a closer look.