-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MacOS for Carthage Dependencies #5
Conversation
Please make sure Travis completes successfully |
Done? |
Apologies that this is stale. I'll poke at this today and see if I can get it working. |
It isn't immediately clear to me why this is failing. There's a couple variables here:
Without updating, I can't get this to build locally and reproduce the failures we see on CI. I do believe this PR works though (and I am actually consuming this PR in a production project from my fork), it's just that the testbed project isn't passing. I opened #9 to address changes to the build system. I'm confident if we can get that to a passing state then we should be able to make this PR pass CI quite easily. |
Update: I actually believe this project is broken at head, see #10. I no longer believe that build breaks are related to this PR. |
@keefertaylor Can you see the actual error message? I will try to fix this at head so we can apply it here. |
Building this library for MacOS with Carthage previously resulted in an error (see #4).
I performed the following steps to upgrade the .xcodeproj for MacOS compatibility with Carthage:
supportedPlatforms
tomacosx
,iphoneos
,iphonesimulator
in build configuration#import <UIKit/UIKit.h>
with#import <Foundation/Foundation.h>
. UIKit imports Foundation, but the source files do not use any UIKit based classes and UIKit is not available on MacOS.To test, I verified that my Carthage based project can now build this library on both iOS and OSX (example PR with continuous CI: keefertaylor/TezosKit#153).
Fixes #4